Re: [Patch net] net: check mac address length for dev_set_mac_address()

2017-07-21 Thread Cong Wang
On Thu, Jul 20, 2017 at 11:27 AM, Cong Wang wrote: > diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c > index 82fd4c9c4a1b..3f41601d7b7c 100644 > --- a/net/core/dev_ioctl.c > +++ b/net/core/dev_ioctl.c > @@ -262,6 +262,8 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, > unsig

Re: [Patch net] net: check mac address length for dev_set_mac_address()

2017-07-20 Thread Cong Wang
On Thu, Jul 20, 2017 at 11:27 AM, Cong Wang wrote: > dev_set_mac_address() accepts a struct sockaddr pointer as > input but we have various types of mac addresse whose lengths > are up to MAX_ADDR_LEN, this is confusing. > > Make it void like ->ndo_set_mac_address() and let callers check > its len

[Patch net] net: check mac address length for dev_set_mac_address()

2017-07-20 Thread Cong Wang
dev_set_mac_address() accepts a struct sockaddr pointer as input but we have various types of mac addresse whose lengths are up to MAX_ADDR_LEN, this is confusing. Make it void like ->ndo_set_mac_address() and let callers check its length before calling it. It is too late to fix dev_ifsioc() due t