From: Cong Wang
Date: Thu, 30 Jun 2016 10:15:22 -0700
> Similar to commit 9b368814b336 ("net: fix bridge multicast packet checksum
> validation")
> we need to fixup the checksum for CHECKSUM_COMPLETE when
> pushing skb on RX path. Otherwise we get similar splats.
>
> Cc: Jamal Hadi Salim
> Cc:
On 16-06-30 01:15 PM, Cong Wang wrote:
Similar to commit 9b368814b336 ("net: fix bridge multicast packet checksum
validation")
we need to fixup the checksum for CHECKSUM_COMPLETE when
pushing skb on RX path. Otherwise we get similar splats.
Cc: Jamal Hadi Salim
Cc: Tom Herbert
Signed-off-by:
On 07/01/2016 01:41 AM, Cong Wang wrote:
On Thu, Jun 30, 2016 at 4:26 PM, Cong Wang wrote:
On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann wrote:
On 07/01/2016 12:42 AM, Cong Wang wrote:
On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann
wrote:
Maybe makes sense to move skb_push_rcsum() b
On Thu, Jun 30, 2016 at 4:26 PM, Cong Wang wrote:
> On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann wrote:
>> On 07/01/2016 12:42 AM, Cong Wang wrote:
>>>
>>> On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann
>>> wrote:
Maybe makes sense to move skb_push_rcsum() but /also/ skb_pu
On Thu, Jun 30, 2016 at 4:11 PM, Daniel Borkmann wrote:
> On 07/01/2016 12:42 AM, Cong Wang wrote:
>>
>> On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann
>> wrote:
>>>
>>>
>>> Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
>>> to the header then? Both seem similarly small
On 07/01/2016 12:42 AM, Cong Wang wrote:
On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann wrote:
Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
to the header then? Both seem similarly small at least (could be split
f.e into two patches then, first for the move, second
On Thu, Jun 30, 2016 at 12:50 PM, Daniel Borkmann wrote:
>
> Maybe makes sense to move skb_push_rcsum() but /also/ skb_pull_rcsum()
> to the header then? Both seem similarly small at least (could be split
> f.e into two patches then, first for the move, second for the actual fix).
No objection fr
Hi Cong,
On 06/30/2016 07:15 PM, Cong Wang wrote:
Similar to commit 9b368814b336 ("net: fix bridge multicast packet checksum
validation")
we need to fixup the checksum for CHECKSUM_COMPLETE when
pushing skb on RX path. Otherwise we get similar splats.
Cc: Jamal Hadi Salim
Cc: Tom Herbert
Sig
Similar to commit 9b368814b336 ("net: fix bridge multicast packet checksum
validation")
we need to fixup the checksum for CHECKSUM_COMPLETE when
pushing skb on RX path. Otherwise we get similar splats.
Cc: Jamal Hadi Salim
Cc: Tom Herbert
Signed-off-by: Cong Wang
---
include/linux/skbuff.h |
