Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-31 Thread Cyrill Gorcunov
On Thu, Jul 28, 2016 at 12:33:58PM +0200, Guillaume Nault wrote: > > > > After staring more I think the patch should be fine as a fix > > since implementing sync with ppp_[re|un]register_channel and > > ppp_ioctl might need a way more work. > > > > [Sorry for arriving so late in the game, I was

Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-28 Thread Guillaume Nault
On Wed, Jul 06, 2016 at 03:25:15PM +0300, Cyrill Gorcunov wrote: > On Wed, Jul 06, 2016 at 11:26:02AM +0300, Cyrill Gorcunov wrote: > > On Tue, Jul 05, 2016 at 10:12:36PM -0700, Cong Wang wrote: > > > Matt reported that we have a NULL pointer dereference > > > in ppp_pernet() from

Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-08 Thread David Miller
From: Cong Wang Date: Tue, 5 Jul 2016 22:12:36 -0700 > Matt reported that we have a NULL pointer dereference > in ppp_pernet() from ppp_connect_channel(), > i.e. pch->chan_net is NULL. > > This is due to that a parallel ppp_unregister_channel() > could happen while we

Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-06 Thread Cyrill Gorcunov
On Wed, Jul 06, 2016 at 11:26:02AM +0300, Cyrill Gorcunov wrote: > On Tue, Jul 05, 2016 at 10:12:36PM -0700, Cong Wang wrote: > > Matt reported that we have a NULL pointer dereference > > in ppp_pernet() from ppp_connect_channel(), > > i.e. pch->chan_net is NULL. > > > > This is due to that a

Re: [Patch net] ppp: defer netns reference release for ppp channel

2016-07-06 Thread Cyrill Gorcunov
On Tue, Jul 05, 2016 at 10:12:36PM -0700, Cong Wang wrote: > Matt reported that we have a NULL pointer dereference > in ppp_pernet() from ppp_connect_channel(), > i.e. pch->chan_net is NULL. > > This is due to that a parallel ppp_unregister_channel() > could happen while we are in

[Patch net] ppp: defer netns reference release for ppp channel

2016-07-05 Thread Cong Wang
Matt reported that we have a NULL pointer dereference in ppp_pernet() from ppp_connect_channel(), i.e. pch->chan_net is NULL. This is due to that a parallel ppp_unregister_channel() could happen while we are in ppp_connect_channel(), during which pch->chan_net set to NULL. Since we need a