Re: [Patch net] tipc: fix a null pointer deref on error path

2017-12-04 Thread Cong Wang
On Mon, Dec 4, 2017 at 4:43 AM, Ying Xue wrote: > On 12/04/2017 11:54 AM, Cong Wang wrote: >> In tipc_topsrv_kern_subscr() when s->tipc_conn_new() fails >> we call tipc_close_conn() to clean up, but in this case >> con->usr_data is NULL, tipc_subscrb_delete() should be skipped. >> >> This fixes th

Re: [Patch net] tipc: fix a null pointer deref on error path

2017-12-04 Thread Ying Xue
On 12/04/2017 11:54 AM, Cong Wang wrote: > In tipc_topsrv_kern_subscr() when s->tipc_conn_new() fails > we call tipc_close_conn() to clean up, but in this case > con->usr_data is NULL, tipc_subscrb_delete() should be skipped. > > This fixes the folllowing crash: > > kasan: GPF could be caused by

[Patch net] tipc: fix a null pointer deref on error path

2017-12-03 Thread Cong Wang
In tipc_topsrv_kern_subscr() when s->tipc_conn_new() fails we call tipc_close_conn() to clean up, but in this case con->usr_data is NULL, tipc_subscrb_delete() should be skipped. This fixes the folllowing crash: kasan: GPF could be caused by NULL-ptr deref or user memory access general protecti