Re: [Patch net] tipc: fix uninit skb->data in tipc_nl_compat_dumpit()

2020-08-16 Thread David Miller
From: Cong Wang Date: Sat, 15 Aug 2020 16:29:15 -0700 > __tipc_nl_compat_dumpit() has two callers, and it expects them to > pass a valid nlmsghdr via arg->data. This header is artificial and > crafted just for __tipc_nl_compat_dumpit(). > > tipc_nl_compat_publ_dump() does so by putting a genlmsg

Re: [Patch net] tipc: fix uninit skb->data in tipc_nl_compat_dumpit()

2020-08-16 Thread Ying Xue
On 8/16/20 7:29 AM, Cong Wang wrote: > __tipc_nl_compat_dumpit() has two callers, and it expects them to > pass a valid nlmsghdr via arg->data. This header is artificial and > crafted just for __tipc_nl_compat_dumpit(). > > tipc_nl_compat_publ_dump() does so by putting a genlmsghdr as well > as so

[Patch net] tipc: fix uninit skb->data in tipc_nl_compat_dumpit()

2020-08-15 Thread Cong Wang
__tipc_nl_compat_dumpit() has two callers, and it expects them to pass a valid nlmsghdr via arg->data. This header is artificial and crafted just for __tipc_nl_compat_dumpit(). tipc_nl_compat_publ_dump() does so by putting a genlmsghdr as well as some nested attribute, TIPC_NLA_SOCK. But the other