Re: [Patch net-next] net_sched: add network namespace support for tc actions

2016-02-22 Thread Cong Wang
On Mon, Feb 22, 2016 at 5:42 AM, Jamal Hadi Salim wrote: > I did a quick look and i am struggling with it. The patch seems largish > The issue is that we need to do this per kernel module so the code > churn maybe unavoidable; hinfo stored in act_ops complicates things. >

Re: [Patch net-next] net_sched: add network namespace support for tc actions

2016-02-22 Thread Jamal Hadi Salim
On 16-02-20 07:46 PM, Cong Wang wrote: On Sat, Feb 20, 2016 at 10:36 AM, Daniel Borkmann wrote: Do you see a way to reduce the code duplication needed across all the action modules? I.e. that each of them now needs to register a new per netns subsystem, etc. In other

Re: [Patch net-next] net_sched: add network namespace support for tc actions

2016-02-20 Thread Cong Wang
On Sat, Feb 20, 2016 at 10:36 AM, Daniel Borkmann wrote: > > Do you see a way to reduce the code duplication needed across all > the action modules? I.e. that each of them now needs to register > a new per netns subsystem, etc. In other words, is there a way the > action API

Re: [Patch net-next] net_sched: add network namespace support for tc actions

2016-02-20 Thread Daniel Borkmann
On 02/20/2016 01:43 AM, Cong Wang wrote: Currently tc actions are stored in a per-module hashtable, therefore are visible to all network namespaces. This is probably the last part of the tc subsystem which is not aware of netns now. This patch makes them per-netns, several tc action API's need

[Patch net-next] net_sched: add network namespace support for tc actions

2016-02-19 Thread Cong Wang
Currently tc actions are stored in a per-module hashtable, therefore are visible to all network namespaces. This is probably the last part of the tc subsystem which is not aware of netns now. This patch makes them per-netns, several tc action API's need to be adjusted for this. The tc action API