Re: [Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len

2018-01-28 Thread Cong Wang
On Fri, Jan 26, 2018 at 6:16 AM, Michael S. Tsirkin wrote: > > This drops all packets in the queue. I don't think tweaking the queue > length did this previously - did it? No, because previously only enqueue reads the value. > If not this change might surprise some people. It is hard to say whi

Re: [Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len

2018-01-26 Thread Michael S. Tsirkin
On Thu, Jan 25, 2018 at 06:26:23PM -0800, Cong Wang wrote: > Introduce a new qdisc ops ->change_tx_queue_len() so that > each qdisc could decide how to implement this if it wants. > Previously we simply read dev->tx_queue_len, after pfifo_fast > switches to skb array, we need this API to resize the

[Patch net-next v3 2/3] net_sched: plug in qdisc ops change_tx_queue_len

2018-01-25 Thread Cong Wang
Introduce a new qdisc ops ->change_tx_queue_len() so that each qdisc could decide how to implement this if it wants. Previously we simply read dev->tx_queue_len, after pfifo_fast switches to skb array, we need this API to resize the skb array when we change dev->tx_queue_len. To avoid handling rac