RE: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-16 Thread David Laight
From: Jamal Hadi Salim > Sent: 13 August 2016 12:34 > > Just minor comment below: > > On 16-08-11 08:41 PM, Cong Wang wrote: > > > > +static inline void > > +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions) > > +{ > > to: > static inline void tcf_exts_to_list(const

Re: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-14 Thread Jamal Hadi Salim
On 16-08-14 01:03 AM, Cong Wang wrote: On Sat, Aug 13, 2016 at 4:33 AM, Jamal Hadi Salim wrote: Just minor comment below: On 16-08-11 08:41 PM, Cong Wang wrote: +static inline void +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions) +{ to:

Re: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-14 Thread Cong Wang
On Sat, Aug 13, 2016 at 4:33 AM, Jamal Hadi Salim wrote: > > Just minor comment below: > > On 16-08-11 08:41 PM, Cong Wang wrote: > > >> +static inline void >> +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions) >> +{ > > > to: > static inline void

Re: [Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-13 Thread Jamal Hadi Salim
Just minor comment below: On 16-08-11 08:41 PM, Cong Wang wrote: +static inline void +tcf_exts_to_list(const struct tcf_exts *exts, struct list_head *actions) +{ to: static inline void tcf_exts_to_list(const struct tcf_exts *exts, struct list_head

[Patch net v3 5/5] net_sched: convert tcf_exts from list to pointer array

2016-08-11 Thread Cong Wang
As pointed out by Jamal, an action could be shared by multiple filters, so we can't use list to chain them any more after we get rid of the original tc_action. Instead, we could just save pointers to these actions in tcf_exts, since they are refcount'ed, so convert the list to an array of