Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-03 Thread Christoph Hellwig
On Wed, Aug 03, 2005 at 12:19:24PM -0300, Arnaldo Carvalho de Melo wrote: > On 8/3/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 03, 2005 at 06:29:25AM -0700, David S. Miller wrote: > > > From: Eric Dumazet <[EMAIL PROTECTED]> > > > Date: Tue, 02 Aug 2005 23:45:27 +0200 > > > > >

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-03 Thread Arnaldo Carvalho de Melo
On 8/3/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Aug 03, 2005 at 06:29:25AM -0700, David S. Miller wrote: > > From: Eric Dumazet <[EMAIL PROTECTED]> > > Date: Tue, 02 Aug 2005 23:45:27 +0200 > > > > > Please move ; in a better place, not > > > just after spinlock_t portalloc_lock;

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-03 Thread Christoph Hellwig
On Wed, Aug 03, 2005 at 06:29:25AM -0700, David S. Miller wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Tue, 02 Aug 2005 23:45:27 +0200 > > > Please move kmem_cache_t *bind_bucket_cachep; in a better place, not > > just after spinlock_t portalloc_lock; > > [ Eric, I haven't had time to

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-03 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 02 Aug 2005 23:45:27 +0200 > Please move kmem_cache_t *bind_bucket_cachep; in a better place, not > just after spinlock_t portalloc_lock; [ Eric, I haven't had time to respond to this thread because I'm in the UK for UKUUG2005 this week, so emai

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-02 Thread Arnaldo Carvalho de Melo
On 8/2/05, Eric Dumazet <[EMAIL PROTECTED]> wrote: > Arnaldo Carvalho de Melo a écrit : > > Hi Eric, > > > > Interesting, I'm reading it now that I finished one more changeset on > > the > > generalisation of all the tcp_hashinfo routines, could you please take > > a look at: > > > > http://w

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-02 Thread Eric Dumazet
Arnaldo Carvalho de Melo a écrit : Hi Eric, Interesting, I'm reading it now that I finished one more changeset on the generalisation of all the tcp_hashinfo routines, could you please take a look at: http://www.kernel.org/git/?p=linux/kernel/git/acme/timewait-2.6.14.git;a=summary ? yes

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-02 Thread Arnaldo Carvalho de Melo
Hi Eric, Interesting, I'm reading it now that I finished one more changeset on the generalisation of all the tcp_hashinfo routines, could you please take a look at: http://www.kernel.org/git/?p=linux/kernel/git/acme/timewait-2.6.14.git;a=summary ? Good thing is that any optimization you do

[RFC,PATCH] Idea to speedup tcp lookups

2005-08-02 Thread Eric Dumazet
Eric Dumazet a écrit : Hi David, Hi all I would like to provide a patch to speedup tcp lookups, but I need your comments first. 1) First some peformance data : tcp_v4_rcv() waste a lot of time in __tcp_v4_lookup_established() The most critical code is : s