Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-28 Thread Herbert Xu
Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > > I understand what you pointed out. But I think the accounting > method I'm proposing is very similar to TCP accounting and per > socket accounting. > How do you think of it? I think allowing Joe user to stop root from using TCP or UDP isn't much better

[RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-28 Thread Satoshi OSHIMA
This patch introduces global variable for UDP memory accounting. The unit is page. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-rc3-udp_limit/include/net/sock.h === --

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-28 Thread Satoshi OSHIMA
Hi, Thank you for your comment. Andi Kleen wrote: > Satoshi OSHIMA <[EMAIL PROTECTED]> writes: > >> This patch introduces global variable for UDP memory accounting. >> The unit is page. > > The global variable doesn't seem to be very MP scalable, especially > if you change it for each packet. Thi

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-27 Thread Hideo AOKI
Hello, I apologize for not replying sooner. Andi Kleen wrote: Satoshi OSHIMA <[EMAIL PROTECTED]> writes: This patch introduces global variable for UDP memory accounting. The unit is page. The global variable doesn't seem to be very MP scalable, especially if you change it for each packet. T

Re: [RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-21 Thread Andi Kleen
Satoshi OSHIMA <[EMAIL PROTECTED]> writes: > This patch introduces global variable for UDP memory accounting. > The unit is page. The global variable doesn't seem to be very MP scalable, especially if you change it for each packet. This will be a very hot cache line, in the worst case bouncing ar

[RFC/PATCH 2/3] UDP memory usage accounting: accounting unit and variable

2007-09-21 Thread Satoshi OSHIMA
This patch introduces global variable for UDP memory accounting. The unit is page. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-rc3-udp_limit/include/net/sock.h === --