Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-22 Thread TAKANO Ryousei
Hi Eric, > > +static struct sk_buff *alloc_gap_packet(struct Qdisc* sch, int size) > > +{ > > + struct sk_buff *skb; > > + struct net_device *dev = sch->dev; > > + unsigned char *pkt; > > + int pause_time = 0; > > + int pktsize = size + 2; > > + > > + skb = alloc_skb(pktsize, GFP_ATOMI

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-22 Thread TAKANO Ryousei
Hi Patrick, > Looks good, but please run checkpatch over it. A few more comments > below. > I am sorry I forgot to run checkpatch. Thanks for your comments. They are very useful for me. I will fix them and resent the patch. Best regards, Ryousei Takano - To unsubscribe from this list: send the l

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread TAKANO Ryousei
I am sorry I send an unfinished mail. > > Also, the idea of using a PAUSE frame to add gaps is interesting, but > > you should note that in linux a qdisc may be attached to any network > > device and this for example maybe a PPP device etc. What would you use > > for gaps in that case? > You are

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
Hi jamal, > Good stuff. > I have not read your paper - There are NICs out there (chelsio comes to > mind) which claim to do pacing and have shown impressive numbers with > TCP. Is your approach similar? Are there patents involved by some of > these hardware vendors? (It would not be suprising if t

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Eric Dumazet
Ryousei Takano a écrit : This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread jamal
On Wed, 2007-21-11 at 19:18 +0900, Ryousei Takano wrote: > This patch includes the PSPacer (Precise Software Pacer) qdisc > module, which achieves precise transmission bandwidth control. > You can find more information at the project web page > (http://www.gridmpi.org/gridtcp.jsp). Good stuff. I h

Re: [RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Patrick McHardy
Ryousei Takano wrote: This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Looks good, but please run checkpatch over it. A few m

[RFC][PATCH 1/3] NET_SCHED: PSPacer qdisc module

2007-11-21 Thread Ryousei Takano
This patch includes the PSPacer (Precise Software Pacer) qdisc module, which achieves precise transmission bandwidth control. You can find more information at the project web page (http://www.gridmpi.org/gridtcp.jsp). Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]> --- include/linux/pkt_sched.h