+++ b/drivers/dma/cb_list.h
@@ -0,0 +1,12 @@
+/* Extra macros that build on linux/list.h */
+#ifndef CB_LIST_H
+#define CB_LIST_H
+
+#include linux/list.h
+
+/* Provide some safty to list_add, which I find easy to swap the arguments
to */
+
+#define list_add_entry(pos, head, member)
Hi,
Jeff Garzik wrote:
explanation of this function would be nice. remember to answer how?
and why?, not what?.
Wasn't it the other way around?
Citing linux/Documentation/CodingStyle, section 7 Comments:
Generally, you want your comments to tell WHAT your code does, not HOW.
HOW and WHY
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 48f446d..fbe5116 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -66,4 +66,6 @@ source drivers/infiniband/Kconfig
source drivers/sn/Kconfig
+source drivers/dma/Kconfig
+
endmenu
diff --git a/drivers/Makefile b/drivers/Makefile
index
Mostly ok, but some minor nits.
Andrew Grover wrote:
index 000..f2cc2d7
--- /dev/null
+++ b/drivers/dma/cb_list.h
@@ -0,0 +1,12 @@
+/* Extra macros that build on linux/list.h */
+#ifndef CB_LIST_H
+#define CB_LIST_H
+
+#include linux/list.h
+
+/* Provide some safty to list_add, which I
On Wed, Nov 23, 2005 at 12:26:42PM -0800, Andrew Grover wrote:
+static void
+dma_class_release(struct class_device *cd)
+{
+ /* do something */
+}
Well, then actually do something here. Don't try to trick the kernel to
not complain about the lack of a release function by giving it an
