Re: [RFC] bridging: don't forward EAPOL frames

2007-11-27 Thread Johannes Berg
+ if (unlikely(skb-protocol = htons(ETH_P_PAE))) + goto drop; + switch (p-state) { case BR_STATE_FORWARDING: Not needed because the bridge is already handling it: 1) If running STP (ie true bridge), then all link local multicast is only received by the

Re: [Bridge] Re: [RFC] bridging: don't forward EAPOL frames

2007-11-27 Thread Andy Gospodarek
On Nov 27, 2007 8:24 AM, Johannes Berg [EMAIL PROTECTED] wrote: + if (unlikely(skb-protocol = htons(ETH_P_PAE))) + goto drop; + switch (p-state) { case BR_STATE_FORWARDING: Not needed because the bridge is already handling it: 1) If running STP (ie true

Re: [Bridge] Re: [RFC] bridging: don't forward EAPOL frames

2007-11-27 Thread Johannes Berg
Not needed because the bridge is already handling it: 1) If running STP (ie true bridge), then all link local multicast is only received by the bridge and never forwarded. Well, typical access point setups bridge the wireless AP interface with wired, EAPOL frames can be

Re: [RFC] bridging: don't forward EAPOL frames

2007-11-26 Thread Stephen Hemminger
On Thu, 22 Nov 2007 14:23:28 +0100 Johannes Berg [EMAIL PROTECTED] wrote: This patch makes the bridging code drop EAPOL frames as recommended by 802.1X-2004 in C.3.3. Is this really the right place to put it? --- include/linux/if_ether.h |1 + include/net/ieee80211.h |6 --

[RFC] bridging: don't forward EAPOL frames

2007-11-22 Thread Johannes Berg
This patch makes the bridging code drop EAPOL frames as recommended by 802.1X-2004 in C.3.3. Is this really the right place to put it? --- include/linux/if_ether.h |1 + include/net/ieee80211.h |6 -- net/bridge/br_input.c|3 +++ 3 files changed, 4 insertions(+), 6