Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-23 Thread Matan Barak
On 22/04/2017 12:28, Ian Kumlien wrote: On Sat, Apr 22, 2017 at 3:07 AM, Saeed Mahameed wrote: On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed wrote: On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: Sorry, Back again, fighting cold,

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-22 Thread Ian Kumlien
On Sat, Apr 22, 2017 at 3:07 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: >> On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed >> wrote: >>> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: Sorry, Back again, fighting cold, hot whiskey has been

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Saeed Mahameed
On Sat, Apr 22, 2017 at 3:47 AM, Ian Kumlien wrote: > On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed > wrote: >> On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >>> Sorry, >>> >>> Back again, fighting cold, hot whiskey has been consumed... >>> >>> Something like this would perhaps be a bett

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Sat, Apr 22, 2017 at 2:34 AM, Saeed Mahameed wrote: > On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: >> Sorry, >> >> Back again, fighting cold, hot whiskey has been consumed... >> >> Something like this would perhaps be a better solution: >> >> diff --git a/drivers/net/ethernet/mellanox/m

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Saeed Mahameed
On Sat, Apr 22, 2017 at 2:10 AM, Ian Kumlien wrote: > Sorry, > > Back again, fighting cold, hot whiskey has been consumed... > > Something like this would perhaps be a better solution: > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c > b/drivers/net/ethernet/mellanox/mlx5/core/main.

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
Sorry, Back again, fighting cold, hot whiskey has been consumed... Something like this would perhaps be a better solution: diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c index 60154a175bd3..fe192e247601 100644 --- a/drivers/net/ethern

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
On Fri, Apr 21, 2017 at 9:47 PM, David Miller wrote: > From: Ian Kumlien > Date: Fri, 21 Apr 2017 21:45:00 +0200 > >> The mellanox driver supports both ethernet and infiniband, but it >> is located in the ethernet drivers - the ethernet support should >> default to 'yes'. > > I don't have that ca

Re: [RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread David Miller
From: Ian Kumlien Date: Fri, 21 Apr 2017 21:45:00 +0200 > The mellanox driver supports both ethernet and infiniband, but it > is located in the ethernet drivers - the ethernet support should > default to 'yes'. I don't have that card and I therefore perhaps don't want that driver in my builds.

[RFC] change the default Kconfig value of mlx5_en

2017-04-21 Thread Ian Kumlien
Hi, For some reason I spend some hours, two days in a row, trying to debug why a newer kernel didn't work on our machines. It worked just fine with the older kernel... And there was no network interfaces to see or try to figure out what was going on with. Playing with the infiniband tools all i