[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-28 Thread Jon Mason
Move the BCMA MDIO phy into a separate file, as it is very tightly coupled with the BCMA bus. This will help with the upcoming BCMA removal from the bgmac driver. Optimally, this should be moved into phy drivers, but it is too tightly coupled with the bgmac driver to effectively move it without m

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-28 Thread Andrew Lunn
On Tue, Jun 28, 2016 at 03:34:40PM -0400, Jon Mason wrote: > Move the BCMA MDIO phy into a separate file, as it is very tightly > coupled with the BCMA bus. This will help with the upcoming BCMA > removal from the bgmac driver. Optimally, this should be moved into > phy drivers, but it is too tig

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Andrew Lunn
Hi Jon I know you are just refactoring code, but at some point it would be good to take a closer look at this MDIO bus driver. The MDIO bus driver should be generic, allowing access to all 32 addresses on the bus, if that makes sense. You could for example have a B53 switch hanging off the MDIO b

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Florian Fainelli
On 06/29/2016 07:13 AM, Andrew Lunn wrote: > Hi Jon > > I know you are just refactoring code, but at some point it would be > good to take a closer look at this MDIO bus driver. > > The MDIO bus driver should be generic, allowing access to all 32 > addresses on the bus, if that makes sense. You c

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Andrew Lunn
On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: > On 06/29/2016 07:13 AM, Andrew Lunn wrote: > > Hi Jon > > > > I know you are just refactoring code, but at some point it would be > > good to take a closer look at this MDIO bus driver. > And, to re-iterate all of your points ar

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Jon Mason
On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: >> > Hi Jon >> > >> > I know you are just refactoring code, but at some point it would be >> > good to take a closer look at this MD

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Andrew Lunn
On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote: > On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: > > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: > >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: > >> > Hi Jon > >> > > >> > I know you are just refactoring code, b

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-29 Thread Jon Mason
On Wed, Jun 29, 2016 at 4:15 PM, Andrew Lunn wrote: > On Wed, Jun 29, 2016 at 04:08:20PM -0400, Jon Mason wrote: >> On Wed, Jun 29, 2016 at 2:46 PM, Andrew Lunn wrote: >> > On Wed, Jun 29, 2016 at 11:35:28AM -0700, Florian Fainelli wrote: >> >> On 06/29/2016 07:13 AM, Andrew Lunn wrote: >> >> > H