From: Hannes Frederic Sowa
Date: Fri, 28 Jul 2017 16:47:42 -0400
> David Miller writes:
>
>> The red flag is that we are indexing 'start' with 'doffset' instead of
>> 'soffset'.
>
> As Paolo pointed out, we should not put our own source address
Hello,
David Miller writes:
> From: Paolo Abeni
> Date: Fri, 21 Jul 2017 15:55:18 +0200
>
>> diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c
>> index 93157f2..fdda973 100644
>> --- a/net/ipv4/ip_options.c
>> +++ b/net/ipv4/ip_options.c
>> @@
On Mon, 2017-07-24 at 14:12 -0700, David Miller wrote:
> From: Paolo Abeni
> Date: Fri, 21 Jul 2017 15:55:18 +0200
>
> > diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c
> > index 93157f2..fdda973 100644
> > --- a/net/ipv4/ip_options.c
> > +++ b/net/ipv4/ip_options.c
From: Paolo Abeni
Date: Fri, 21 Jul 2017 15:55:18 +0200
> diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c
> index 93157f2..fdda973 100644
> --- a/net/ipv4/ip_options.c
> +++ b/net/ipv4/ip_options.c
> @@ -174,9 +174,6 @@ int __ip_options_echo(struct ip_options *dopt,
While computing the response option set for LRSS, ip_options_echo()
also changes the ingress packet LRSS addresses list, setting
the last one to the dst specific address for the ingress packet
- via memset(start[ ...
The only visible effect of such change - beyond possibly damaging
shared/cloned