Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-16 Thread chetan L
On Thu, Nov 16, 2017 at 8:53 AM, Jesper Dangaard Brouer wrote: > On Wed, 15 Nov 2017 14:21:38 -0800 > chet l wrote: > >> One quick question: >> Any thoughts on SVM support? > > What is SVM ? > Shared Virtual Memory(PCIe based). So going back to one of your mapping examples. The protocol can be A

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-16 Thread chetan L
On Wed, Nov 15, 2017 at 5:44 PM, David Miller wrote: > From: chet l > Date: Wed, 15 Nov 2017 14:34:32 -0800 > >> I have not reviewed the entire patchset but I think if we could add a >> version_hdr and then unionize the fields, it might be easier to add >> SVM support without having to spin v5. I

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-16 Thread Jesper Dangaard Brouer
On Wed, 15 Nov 2017 14:21:38 -0800 chet l wrote: > One quick question: > Any thoughts on SVM support? What is SVM ? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-15 Thread David Miller
From: chet l Date: Wed, 15 Nov 2017 14:34:32 -0800 > I have not reviewed the entire patchset but I think if we could add a > version_hdr and then unionize the fields, it might be easier to add > SVM support without having to spin v5. I could be wrong though. Please, NO VERSION FIELDS! Design th

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-15 Thread chet l
On Tue, Oct 31, 2017 at 5:41 AM, Björn Töpel wrote: > From: Björn Töpel > > +/* > + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG > + * to register user memory which should be used to store the packet > + * data. > + * > + * There are some constraints for the memory being

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-15 Thread chet l
> > Actually, we started out with that approach, where the packet_mmap > call mapped Tx/Rx descriptor rings and the packet buffer region. We > later moved to this (register umem) approach, because it's more > flexible for user space, not having to use a AF_PACKET specific > allocator (i.e. continue

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-03 Thread Björn Töpel
2017-11-03 3:29 GMT+01:00 Willem de Bruijn : +/* + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG + * to register user memory which should be used to store the packet + * data. + * + * There are some constraints for the memory being registered: >

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Willem de Bruijn
>>> +/* >>> + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG >>> + * to register user memory which should be used to store the packet >>> + * data. >>> + * >>> + * There are some constraints for the memory being registered: >>> + * - The memory area has to be memory page size

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Björn Töpel
2017-11-02 17:40 GMT+01:00 Tushar Dave : > > > On 11/02/2017 03:06 AM, Björn Töpel wrote: >> >> On 2017-11-02 02:45, Willem de Bruijn wrote: >>> >>> On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel >>> wrote: From: Björn Töpel This patch adds the necessary AF_PACKET V4 structures

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Tushar Dave
On 11/02/2017 03:06 AM, Björn Töpel wrote: On 2017-11-02 02:45, Willem de Bruijn wrote: On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: From: Björn Töpel This patch adds the necessary AF_PACKET V4 structures for usage from userspace. AF_PACKET V4 is a new interface optimized for high p

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Björn Töpel
On 2017-11-02 02:45, Willem de Bruijn wrote: > On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: >> From: Björn Töpel >> >> This patch adds the necessary AF_PACKET V4 structures for usage from >> userspace. AF_PACKET V4 is a new interface optimized for high >> performance packet processing. >>

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: > From: Björn Töpel > > This patch adds the necessary AF_PACKET V4 structures for usage from > userspace. AF_PACKET V4 is a new interface optimized for high > performance packet processing. > > Signed-off-by: Björn Töpel > --- > include/uapi/l

[RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-10-31 Thread Björn Töpel
From: Björn Töpel This patch adds the necessary AF_PACKET V4 structures for usage from userspace. AF_PACKET V4 is a new interface optimized for high performance packet processing. Signed-off-by: Björn Töpel --- include/uapi/linux/if_packet.h | 65 +- 1 f