Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-22 Thread Herbert Xu
On Thu, Nov 22, 2007 at 03:11:35PM +0200, Ilpo Järvinen wrote: > > ...We'll be using current MTU sized packets except for the probe until > the probe has succeeded, only from that point onward will the new packets > will be sent with the larger MTU. If the probe succeeds, all reservations > we made

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-22 Thread Ilpo Järvinen
On Thu, 22 Nov 2007, Herbert Xu wrote: > On Wed, Nov 21, 2007 at 06:01:27PM +0200, Ilpo Järvinen wrote: > > > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > > Thanks for the patch Ilpo! > > I've just got a couple small questions. ...Thanks for actually commenting it. :-) > > @@ -1307,6 +1

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-22 Thread Herbert Xu
On Wed, Nov 21, 2007 at 06:01:27PM +0200, Ilpo Järvinen wrote: > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Thanks for the patch Ilpo! I've just got a couple small questions. > @@ -1307,6 +1308,7 @@ static int tcp_mtu_probe(struct sock *sk) > /* Very simple search strategy: just do

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-21 Thread John Heffner
Ilpo Järvinen wrote: It seems that the checked range for receiver window check should begin from the first rather than from the last skb that is going to be included to the probe. And that can be achieved without reference to skbs at all, snd_nxt and write_seq provides the correct seqno already.

[RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data available checks fixed

2007-11-21 Thread Ilpo Järvinen
It seems that the checked range for receiver window check should begin from the first rather than from the last skb that is going to be included to the probe. And that can be achieved without reference to skbs at all, snd_nxt and write_seq provides the correct seqno already. Plus, it SHOULD account