Re: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-31 Thread Alexander Duyck
On Wed, Aug 31, 2016 at 4:31 AM, Yuval Mintz wrote: > One question I have regarding the feature, regarding the > partial offload compatible with ndo_features_check(). > > Consider the following example - > Let's assume my adapter is capable of doing outer-csum validation >

RE: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-31 Thread Yuval Mintz
One question I have regarding the feature, regarding the partial offload compatible with ndo_features_check(). Consider the following example - Let's assume my adapter is capable of doing outer-csum validation for vxlan packets, but only if inner network protocol is IPv4, while at the same time

Re: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-25 Thread Alexander Duyck
On Wed, Aug 24, 2016 at 10:06 PM, Yuval Mintz wrote: >> >> This patch assumes that the bnx2x hardware will ignore existing >> >> IPv4/v6 header fields for length and checksum as well as the length >> >> and checksum fields for outer UDP and GRE headers. >> >> >> >> I have

RE: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-24 Thread Yuval Mintz
> >> This patch assumes that the bnx2x hardware will ignore existing > >> IPv4/v6 header fields for length and checksum as well as the length > >> and checksum fields for outer UDP and GRE headers. > >> > >> I have no means of testing this as I do not have any bnx2x hardware > >> but thought I

Re: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-24 Thread Alexander Duyck
On Wed, Aug 24, 2016 at 5:33 AM, Yuval Mintz wrote: >> This patch assumes that the bnx2x hardware will ignore existing IPv4/v6 >> header >> fields for length and checksum as well as the length and checksum fields for >> outer UDP and GRE headers. >> >> I have no means of

RE: [RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-08-24 Thread Yuval Mintz
> This patch assumes that the bnx2x hardware will ignore existing IPv4/v6 header > fields for length and checksum as well as the length and checksum fields for > outer UDP and GRE headers. > > I have no means of testing this as I do not have any bnx2x hardware but > thought > I would submit it

[RFC PATCH 3/5] bnx2x: Add support for segmentation of tunnels with outer checksums

2016-04-19 Thread Alexander Duyck
This patch assumes that the bnx2x hardware will ignore existing IPv4/v6 header fields for length and checksum as well as the length and checksum fields for outer UDP and GRE headers. I have no means of testing this as I do not have any bnx2x hardware but thought I would submit it as an RFC to see