[RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt [EMAIL PROTECTED] Signed-off-by: Christian Limpach [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Arjan van de Ven
On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote: + +/** Send a packet on a net device to encourage switches to learn the + * MAC. We send a fake ARP request. + * + * @param dev device + * @return 0 on success, error code otherwise + */ +static int send_fake_arp(struct net_device

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Keir Fraser
On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation shouldn't the ifup/ifconfig scripts just be fixed instead if this is

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Arjan van de Ven
On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote: On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation shouldn't the

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Dave Boutcher
On Tue, 18 Jul 2006 12:42:28 +0200, Arjan van de Ven [EMAIL PROTECTED] said: On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote: On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread jamal
On Tue, 2006-18-07 at 12:27 +0200, Arjan van de Ven wrote: Hmmm maybe it's me, but something bugs me if a NIC driver is going to send IP level ARP packets... that just feels very very wrong and is a blatant layering violation It is but the bonding driver has been setting precedence for

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
jamal [EMAIL PROTECTED] wrote: I dont think the ifup/ifconfig provide operational status (i.e link up/down) - or do they? If they can be made to invoke scripts in such a case then we are set. In fact, that's a very good reason why this shouldn't be in netfront. Indeed, it shouldn't be in the

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread John Haller
Herbert Xu wrote: jamal [EMAIL PROTECTED] wrote: I dont think the ifup/ifconfig provide operational status (i.e link up/down) - or do they? If they can be made to invoke scripts in such a case then we are set. In fact, that's a very good reason why this shouldn't be in netfront. Indeed, it

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
John Haller [EMAIL PROTECTED] wrote: But sending ARPs is not the right thing if the guest is expecting to use IPv6 networking, in which case unsolicited neighbor advertisements are the right thing to do. The driver just doesn't seem to be the right place to do this, as it doesn't/ shouldn't

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread David Miller
From: Chris Wright [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 00:00:32 -0700 +#ifdef CONFIG_XEN_BALLOON +#include xen/balloon.h +#endif Let's put the ifdefs in xen/balloon.h not in the files including it. +#ifdef CONFIG_XEN_BALLOON + /* Tell the ballon driver what is going on. */ +

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: From: Chris Wright [EMAIL PROTECTED] Date: Tue, 18 Jul 2006 00:00:32 -0700 +#ifdef CONFIG_XEN_BALLOON +#include xen/balloon.h +#endif Let's put the ifdefs in xen/balloon.h not in the files including it. +#ifdef CONFIG_XEN_BALLOON + /*

Re: [RFC PATCH 32/33] Add the Xen virtual network device driver.

2006-07-18 Thread Herbert Xu
Stephen Hemminger [EMAIL PROTECTED] wrote: diff -r eadc12b20f35 drivers/xen/netfront/netfront.c --- /dev/null Thu Jan 01 00:00:00 1970 + +++ b/drivers/xen/netfront/netfront.c Fri Jun 09 15:03:12 2006 -0400 @@ -0,0 +1,1584 @@ +static inline void init_skb_shinfo(struct sk_buff *skb) +{