Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, On Mon, Jan 04, 2016 at 12:59:15PM -0700, David Ahern wrote: > cgroups have very nice properties that I want to leverage such as > parent-child inheritance and easy tracking which subsystem instance a task > belongs. This provides a great kernel foundation for building easy to use > managem

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
On 1/4/16 12:23 PM, Tejun Heo wrote: I don't have an answer for that but cgroup isn't a place to put such stray configurations either. Please figure out where the configuration belongs first. What you're proposing really isn't a resource controller. There's no resource being distributed hierar

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, David. On Mon, Jan 04, 2016 at 12:17:08PM -0700, David Ahern wrote: > None of the existing subsystems are relevant for configuring an L3 > networking domain, and it does not make sense to tie net_cls and net_prio to > an L3 domain. I don't have an answer for that but cgroup isn't a place t

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
On 1/4/16 11:59 AM, Tejun Heo wrote: Hello, David. On Mon, Jan 04, 2016 at 11:53:55AM -0700, David Ahern wrote: On 1/4/16 10:58 AM, Tejun Heo wrote: Please don't create any new controller whose sole purpose is identifying group membership. Please take a look at how libxt_cgroup handles identi

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, David. On Mon, Jan 04, 2016 at 11:53:55AM -0700, David Ahern wrote: > On 1/4/16 10:58 AM, Tejun Heo wrote: > >Please don't create any new controller whose sole purpose is > >identifying group membership. Please take a look at how libxt_cgroup > >handles identification w/o creating a new co

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
Hi Tejun: On 1/4/16 10:58 AM, Tejun Heo wrote: Please don't create any new controller whose sole purpose is identifying group membership. Please take a look at how libxt_cgroup handles identification w/o creating a new controller. http://lkml.kernel.org/g/1449527935-27056-1-git-send-email...

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, David. On Mon, Jan 04, 2016 at 08:32:16AM -0800, David Ahern wrote: > Add cgroup to assoicate tasks with L3 networking domains. AF_INET{6} > sockets opened by tasks associated with an l3mdev cgroup are bound to > the associated master device when the socket is created. This allows a > user

[RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
Add cgroup to assoicate tasks with L3 networking domains. AF_INET{6} sockets opened by tasks associated with an l3mdev cgroup are bound to the associated master device when the socket is created. This allows a user to run a command (and its children) within an L3 networking context. The master-dev