Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-10 Thread Alexander Duyck
On 06/08/2015 11:35 AM, Shrijeet Mukherjee wrote: From: Shrijeet Mukherjee This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavemen

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-09 Thread Shrijeet Mukherjee
On Tue, Jun 9, 2015 at 5:35 AM, Nikolay Aleksandrov wrote: > On Mon, Jun 8, 2015 at 8:35 PM, Shrijeet Mukherjee > wrote: > > vrf_kill_one_slave() calls netdev_rx_handler_unregister() which does > synchronize_rcu() and > here you're running with the queue spinlock held and softirqs disabled. >

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-09 Thread Nikolay Aleksandrov
On Mon, Jun 8, 2015 at 8:35 PM, Shrijeet Mukherjee wrote: > From: Shrijeet Mukherjee > > This driver borrows heavily from IPvlan and teaming drivers. > > Routing domains (VRF-lite) are created by instantiating a device > and enslaving all routed interfaces that participate in the domain. > As par

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-09 Thread Nicolas Dichtel
Le 08/06/2015 20:35, Shrijeet Mukherjee a écrit : From: Shrijeet Mukherjee [snip] --- /dev/null +++ b/drivers/net/vrf.c [snip] + +static struct rtnl_link_ops vrf_link_ops __read_mostly = { + .kind = DRV_NAME, + .priv_size = sizeof(struct net_vrf), + .policy

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread Hannes Frederic Sowa
Hi, On Mo, 2015-06-08 at 11:35 -0700, Shrijeet Mukherjee wrote: > From: Shrijeet Mukherjee > > This driver borrows heavily from IPvlan and teaming drivers. > > Routing domains (VRF-lite) are created by instantiating a device > and enslaving all routed interfaces that participate in the domain.

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread David Ahern
On 6/8/15 12:35 PM, Shrijeet Mukherjee wrote: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 019fcef..27a333c 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -283,6 +283,12 @@ config NLMON diagnostics, etc. This is mostly intended for developers or support

[RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to enslaved devices are