Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-18 Thread Jason Gunthorpe
On Wed, Jan 18, 2017 at 07:43:54AM +0200, Leon Romanovsky wrote: > > I have started working on porting hfi_vnic as per this new interface. > > I will post RFC v3 later. > > Posting the interface definition early for comments. > > I wonder how many people will comment it without seeing usage exampl

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-17 Thread Leon Romanovsky
On Tue, Jan 17, 2017 at 11:27:20AM -0800, Vishwanathapura, Niranjana wrote: > Thanks Jason for the valuable inputs. > > Here is the new generic interface. > > Overview: > Bottom driver defines net_device_ops. The upper driver can override it. > For example, upper driver can implement ndo_open() whi

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-17 Thread Vishwanathapura, Niranjana
Thanks Jason for the valuable inputs. Here is the new generic interface. Overview: Bottom driver defines net_device_ops. The upper driver can override it. For example, upper driver can implement ndo_open() which calls bottom driver's ndo_open() and also do some book keeping. include/rdma/ib_

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-11 Thread Leon Romanovsky
On Wed, Jan 11, 2017 at 01:05:39AM -0800, Vishwanathapura, Niranjana wrote: > On Tue, Jan 10, 2017 at 10:14:02AM +0200, Leon Romanovsky wrote: > > On Mon, Jan 09, 2017 at 07:39:54PM -0800, Vishwanathapura, Niranjana wrote: > > > We are also looking into Jason’s suggestion to make hfi_vnic interface

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-11 Thread Vishwanathapura, Niranjana
On Tue, Jan 10, 2017 at 10:14:02AM +0200, Leon Romanovsky wrote: On Mon, Jan 09, 2017 at 07:39:54PM -0800, Vishwanathapura, Niranjana wrote: We are also looking into Jason’s suggestion to make hfi_vnic interface to the bottom driver a generic interface. This will include moving some of the netst

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-10 Thread Leon Romanovsky
On Mon, Jan 09, 2017 at 07:39:54PM -0800, Vishwanathapura, Niranjana wrote: > On Mon, Jan 09, 2017 at 09:51:04AM +0200, Leon Romanovsky wrote: > > On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > > > On 12/15/2016 9:52 AM, ira.weiny wrote: > > > > > > 2) With more than 60% of the cod

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-09 Thread Vishwanathapura, Niranjana
On Mon, Jan 09, 2017 at 09:51:04AM +0200, Leon Romanovsky wrote: On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: On 12/15/2016 9:52 AM, ira.weiny wrote: 2) With more than 60% of the code being MAD related, and another significant chunk being hfi related, and only a minor bit (20%

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2017-01-08 Thread Leon Romanovsky
On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > On 12/15/2016 9:52 AM, ira.weiny wrote: > > 2) With more than 60% of the code being MAD related, and another > significant chunk being hfi related, and only a minor bit (20% maybe?) > being net related, Hi Doug and Ira, I may admit t

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Jason Gunthorpe
On Thu, Dec 15, 2016 at 08:24:05PM -0500, ira.weiny wrote: > > The main share is the 'skb send' part, we've talked about hoisting > > that out of ipoib in the past anyhow. A generic verb along those lines > > would probably allow the sdma optimization for hfi for both this new > > ulp and ipoib wit

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Vishwanathapura, Niranjana
On Thu, Dec 15, 2016 at 09:56:11AM -0700, Jason Gunthorpe wrote: On Wed, Dec 14, 2016 at 11:59:32PM -0800, Vishwanathapura, Niranjana wrote: create mode 100644 drivers/infiniband/sw/intel/hfi_vnic/Kconfig create mode 100644 drivers/infiniband/sw/intel/hfi_vnic/Makefile Stil NAK on these path

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Vishwanathapura, Niranjana
On Thu, Dec 15, 2016 at 10:07:13AM -0700, Jason Gunthorpe wrote: On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: 1) Since your intent is to make this work with multiple versions of the hfi drivers, I disagree with Jason that just because there is only one driver today that we shou

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Vishwanathapura, Niranjana
On Thu, Dec 15, 2016 at 08:24:05PM -0500, ira.weiny wrote: On Thu, Dec 15, 2016 at 11:48:37AM -0700, Jason Gunthorpe wrote: On Thu, Dec 15, 2016 at 01:19:18PM -0500, Doug Ledford wrote: > On 12/15/2016 12:07 PM, Jason Gunthorpe wrote: > > On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wr

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread ira.weiny
On Thu, Dec 15, 2016 at 11:48:37AM -0700, Jason Gunthorpe wrote: > On Thu, Dec 15, 2016 at 01:19:18PM -0500, Doug Ledford wrote: > > On 12/15/2016 12:07 PM, Jason Gunthorpe wrote: > > > On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > > > > > >> 1) Since your intent is to make this

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Jason Gunthorpe
On Thu, Dec 15, 2016 at 01:19:18PM -0500, Doug Ledford wrote: > On 12/15/2016 12:07 PM, Jason Gunthorpe wrote: > > On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > > > >> 1) Since your intent is to make this work with multiple versions of the > >> hfi drivers, I disagree with Jason

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Doug Ledford
On 12/15/2016 12:07 PM, Jason Gunthorpe wrote: > On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > >> 1) Since your intent is to make this work with multiple versions of the >> hfi drivers, I disagree with Jason that just because there is only one >> driver today that we should keep

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Jason Gunthorpe
On Thu, Dec 15, 2016 at 11:28:06AM -0500, Doug Ledford wrote: > 1) Since your intent is to make this work with multiple versions of the > hfi drivers, I disagree with Jason that just because there is only one > driver today that we should keep it simple. Design it right from the > beginning of mu

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Jason Gunthorpe
On Wed, Dec 14, 2016 at 11:59:32PM -0800, Vishwanathapura, Niranjana wrote: > create mode 100644 drivers/infiniband/sw/intel/hfi_vnic/Kconfig > create mode 100644 drivers/infiniband/sw/intel/hfi_vnic/Makefile Stil NAK on these paths, I already explained why 'sw' is totally unsuitable. Put it in

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Doug Ledford
On 12/15/2016 9:52 AM, ira.weiny wrote: > On Thu, Dec 15, 2016 at 11:12:26AM +0200, Leon Romanovsky wrote: >> On Wed, Dec 14, 2016 at 11:59:32PM -0800, Vishwanathapura, Niranjana wrote: >>> Thanks Jason for the valuable feedback. >>> Here is the revised HFI VNIC patch series. >>> >>> ChangeLog: >>>

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread ira.weiny
On Thu, Dec 15, 2016 at 11:12:26AM +0200, Leon Romanovsky wrote: > On Wed, Dec 14, 2016 at 11:59:32PM -0800, Vishwanathapura, Niranjana wrote: > > Thanks Jason for the valuable feedback. > > Here is the revised HFI VNIC patch series. > > > > ChangeLog: > > = > > v1 => v2: > > a) Removed hfi

Re: [RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Leon Romanovsky
On Wed, Dec 14, 2016 at 11:59:32PM -0800, Vishwanathapura, Niranjana wrote: > Thanks Jason for the valuable feedback. > Here is the revised HFI VNIC patch series. > > ChangeLog: > = > v1 => v2: > a) Removed hfi_vnic bus, instead make hfi_vnic driver an 'ib client', >as per feedback from

[RFC v2 00/10] HFI Virtual Network Interface Controller (VNIC)

2016-12-15 Thread Vishwanathapura, Niranjana
Thanks Jason for the valuable feedback. Here is the revised HFI VNIC patch series. ChangeLog: = v1 => v2: a) Removed hfi_vnic bus, instead make hfi_vnic driver an 'ib client', as per feedback from Jason Gunthorpe. b) Interface changes, data structure changes and variable name changes