On Thu, 2015-08-20 at 19:34 +, Grumbach, Emmanuel wrote:
>
> Err... no :( It won't work for me because the MSS impacts the number of
> segments which in turns impact the number of time the headers have to be
> copied which impacts... the A-MSDU maximal size which must be bigger
> than gso_max
On 08/20/2015 04:53 PM, Grumbach, Emmanuel wrote:
>
>
> On 08/20/2015 04:11 PM, Eric Dumazet wrote:
>> On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote:
>>>
>>> On 08/19/2015 11:39 PM, Eric Dumazet wrote:
On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
> Hm
On Thu, 2015-08-20 at 13:53 +, Grumbach, Emmanuel wrote:
> I do keep the original skb: it becomes the first 802.11 packet generated
> from that LSO skb. Thing is that it will be freed first and I wanted the
> *last packet* to release the pressure on the socket.
Just change this to free it las
On 08/20/2015 04:11 PM, Eric Dumazet wrote:
> On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote:
>>
>> On 08/19/2015 11:39 PM, Eric Dumazet wrote:
>>> On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
>>>
Hm.. how would net/core/tso.c avoid this?
>>>
>>> Because a driver
On Thu, 2015-08-20 at 06:21 +, Grumbach, Emmanuel wrote:
>
> On 08/19/2015 11:39 PM, Eric Dumazet wrote:
> > On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
> >
> >> Hm.. how would net/core/tso.c avoid this?
> >
> > Because a driver using these helpers keep around the original L
On 08/20/2015 10:21 AM, Grumbach, Emmanuel wrote:
>
>
> On 08/19/2015 11:39 PM, Eric Dumazet wrote:
>> On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
>>
>>> Hm.. how would net/core/tso.c avoid this?
>>
>> Because a driver using these helpers keep around the original LSO packet
>>
On 08/19/2015 11:39 PM, Eric Dumazet wrote:
> On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
>
>> Hm.. how would net/core/tso.c avoid this?
>
> Because a driver using these helpers keep around the original LSO packet
> and frees it normally at TX completion time.
>
>> I can't see
On 08/19/2015 11:39 PM, Eric Dumazet wrote:
> On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
>
>> Hm.. how would net/core/tso.c avoid this?
>
> Because a driver using these helpers keep around the original LSO packet
> and frees it normally at TX completion time.
>
Which is why
On Wed, 2015-08-19 at 19:17 +, Grumbach, Emmanuel wrote:
> Hm.. how would net/core/tso.c avoid this?
Because a driver using these helpers keep around the original LSO packet
and frees it normally at TX completion time.
> I can't see anything related to truesize there.
> Note that this work s
On 08/19/2015 05:24 PM, Eric Dumazet wrote:
> On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
>> This allows to release the backpressure on the socket only
>> when the last segment is released.
>> Now the truesize looks like this:
>> if the truesize of the original skb is 65420, all t
On 08/19/2015 10:12 PM, Grumbach, Emmanuel wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and the
last o
Hi,
On 08/19/2015 10:10 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote:
>
>> This allows to release the backpressure on the socket only
>> when the last segment is released.
>> Now the truesize looks like this:
>> if the truesize of the original skb is 65
Hello.
On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and the
On Wed, 2015-08-19 at 15:59 +0300, Emmanuel Grumbach wrote:
> This allows to release the backpressure on the socket only
> when the last segment is released.
> Now the truesize looks like this:
> if the truesize of the original skb is 65420, all the
> segments will have a truesize of 704 (skb itsel
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and the
last one will have 65420.
Change-Id: I3c894cf2afc0aedfe7b2
15 matches
Mail list logo
