Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-13 Thread Vlad Yasevich
Hi Sridhar Sridhar Samudrala wrote: Vlad, few minor comments inline. otherwise, looks good. Thanks Sridhar diff --git a/net/sctp/ipv6.c b/net/sctp/ipv6.c index f8aa23d..54ff472 100644 --- a/net/sctp/ipv6.c +++ b/net/sctp/ipv6.c @@ -77,13 +77,18 @@ #include asm/uaccess.h -/*

[RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Vlad Yasevich
sctp_localaddr_list is modified dynamically via NETDEV_UP and NETDEV_DOWN events, but there is not synchronization between writer (even handler) and readers. As a result, the readers can access an entry that has been freed and crash the sytem. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] ---

Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Paul E. McKenney
On Wed, Sep 12, 2007 at 03:46:37PM -0400, Vlad Yasevich wrote: sctp_localaddr_list is modified dynamically via NETDEV_UP and NETDEV_DOWN events, but there is not synchronization between writer (even handler) and readers. As a result, the readers can access an entry that has been freed and

Re: [RFC v2 PATCH 1/2] SCTP: Add RCU synchronization around sctp_localaddr_list

2007-09-12 Thread Sridhar Samudrala
Vlad, few minor comments inline. otherwise, looks good. Thanks Sridhar On Wed, 2007-09-12 at 15:46 -0400, Vlad Yasevich wrote: sctp_localaddr_list is modified dynamically via NETDEV_UP and NETDEV_DOWN events, but there is not synchronization between writer (even handler) and readers. As a