Re: [RFT] bridge: eliminate port_check workqueue

2007-02-22 Thread Jarek Poplawski
On Wed, Feb 21, 2007 at 10:55:55AM -0800, Stephen Hemminger wrote: > This is what I was suggesting by getting rid of the work queue completely. ... > --- bridge.orig/net/bridge/br_if.c2007-02-21 10:22:46.0 -0800 > +++ bridge/net/bridge/br_if.c 2007-02-21 10:53:25.0 -0800 > @@ -7

Re: [RFT] bridge: eliminate port_check workqueue

2007-02-21 Thread Oleg Nesterov
On 02/21, Stephen Hemminger wrote: > > I would rather put it in a bugfix patchset for 2.6.21 and 2.6.20-stable OK. Even better. Could you also remove br_private.h:BR_PORT_DEBOUNCE then? Oleg. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: [RFT] bridge: eliminate port_check workqueue

2007-02-21 Thread Stephen Hemminger
On Wed, 21 Feb 2007 23:09:16 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > On 02/21, Stephen Hemminger wrote: > > > > This is what I was suggesting by getting rid of the work queue completely. > > Can't comment this patch, but if we can get rid of the work_struct - good! > > > -static void po

Re: [RFT] bridge: eliminate port_check workqueue

2007-02-21 Thread Oleg Nesterov
On 02/21, Stephen Hemminger wrote: > > This is what I was suggesting by getting rid of the work queue completely. Can't comment this patch, but if we can get rid of the work_struct - good! > -static void port_carrier_check(struct work_struct *work) > +void br_port_carrier_check(struct net_bridge_

[RFT] bridge: eliminate port_check workqueue

2007-02-21 Thread Stephen Hemminger
This is what I was suggesting by getting rid of the work queue completely. --- net/bridge/br_if.c | 34 -- net/bridge/br_notify.c | 25 +++-- net/bridge/br_private.h |5 ++--- 3 files changed, 21 insertions(+), 43 deletions(-) ---