Re: [RFT net] net: ipa: fix u32_replace_bits by u32p_xxx version

2020-09-09 Thread Alex Elder
On 9/8/20 9:32 AM, Vadym Kochan wrote: > Looks like u32p_replace_bits() should be used instead of > u32_replace_bits() which does not modifies the value but returns the > modified version. > > Fixes: 2b9feef2b6c2 ("soc: qcom: ipa: filter and routing tables") > Signed-off-by: Vadym Kochan You are

Re: [RFT net] net: ipa: fix u32_replace_bits by u32p_xxx version

2020-09-09 Thread Vadym Kochan
Hi Alex, On Wed, Sep 09, 2020 at 06:53:17AM -0500, Alex Elder wrote: > On 9/8/20 9:32 AM, Vadym Kochan wrote: > > Looks like u32p_replace_bits() should be used instead of > > u32_replace_bits() which does not modifies the value but returns the > > modified version. > > > > Fixes: 2b9feef2b6c2 ("s

Re: [RFT net] net: ipa: fix u32_replace_bits by u32p_xxx version

2020-09-09 Thread Alex Elder
On 9/9/20 7:02 AM, Vadym Kochan wrote: > Hi Alex, > > On Wed, Sep 09, 2020 at 06:53:17AM -0500, Alex Elder wrote: >> On 9/8/20 9:32 AM, Vadym Kochan wrote: >>> Looks like u32p_replace_bits() should be used instead of >>> u32_replace_bits() which does not modifies the value but returns the >>> modi

[RFT net] net: ipa: fix u32_replace_bits by u32p_xxx version

2020-09-08 Thread Vadym Kochan
Looks like u32p_replace_bits() should be used instead of u32_replace_bits() which does not modifies the value but returns the modified version. Fixes: 2b9feef2b6c2 ("soc: qcom: ipa: filter and routing tables") Signed-off-by: Vadym Kochan --- Found it while grepping of u32_replace_bits() usage and