[SOCK]: Adds a rcu_dereference() in sk_filter

2008-01-08 Thread Eric Dumazet
It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference() Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former. Signed-off-by: Eric Dumazet [EMAIL PROTECTED]

Re: [SOCK]: Adds a rcu_dereference() in sk_filter

2008-01-08 Thread Herbert Xu
Eric Dumazet [EMAIL PROTECTED] wrote: It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference() Either we need a rcu_dereference(), either a comment should explain why we dont need it. I vote for the former.

Re: [SOCK]: Adds a rcu_dereference() in sk_filter

2008-01-08 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 09 Jan 2008 17:17:06 +1100 Eric Dumazet [EMAIL PROTECTED] wrote: It seems commit fda9ef5d679b07c9d9097aaf6ef7f069d794a8f9 introduced a RCU protection for sk_filter(), without a rcu_dereference() Either we need a rcu_dereference(), either