Re: [bpf-next V2 PATCH 7/8] bpf/xdp: non-map redirect can avoid calling ndo_xdp_flush

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > This is the first real user of the XDP_XMIT_FLUSH flag. > > As pointed out many times, XDP_REDIRECT without using BPF maps is > significant slower than the map variant. This is primary due to the > lack of bulking, as the ndo_xdp_fl

[bpf-next V2 PATCH 7/8] bpf/xdp: non-map redirect can avoid calling ndo_xdp_flush

2018-05-31 Thread Jesper Dangaard Brouer
This is the first real user of the XDP_XMIT_FLUSH flag. As pointed out many times, XDP_REDIRECT without using BPF maps is significant slower than the map variant. This is primary due to the lack of bulking, as the ndo_xdp_flush operation is required after each frame (to avoid frames hanging on th