Re: [bpf PATCH 3/3] bpf: sockmap, fix error handling in redirect failures

2018-05-02 Thread Alexei Starovoitov
On Wed, May 02, 2018 at 10:47:37AM -0700, John Fastabend wrote: > When a redirect failure happens we release the buffers in-flight > without calling a sk_mem_uncharge(), the uncharge is called before > dropping the sock lock for the redirecte, however we missed updating > the ring start index. When

Re: [bpf PATCH 3/3] bpf: sockmap, fix error handling in redirect failures

2018-05-02 Thread David Miller
From: John Fastabend Date: Wed, 02 May 2018 10:47:37 -0700 > When a redirect failure happens we release the buffers in-flight > without calling a sk_mem_uncharge(), the uncharge is called before > dropping the sock lock for the redirecte, however we missed updating > the ring start index. When no

[bpf PATCH 3/3] bpf: sockmap, fix error handling in redirect failures

2018-05-02 Thread John Fastabend
When a redirect failure happens we release the buffers in-flight without calling a sk_mem_uncharge(), the uncharge is called before dropping the sock lock for the redirecte, however we missed updating the ring start index. When no apply actions are in progress this is OK because we uncharge the ent