Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-02-08 Thread Phil Sutter
Hi, On Thu, Feb 08, 2018 at 02:26:05PM +0100, Élie Bouttier wrote: > On 24/01/2018 16:44, Stephen Hemminger wrote: > > On Wed, 24 Jan 2018 10:19:24 +0100 > > Phil Sutter wrote: > >> On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: > >>> The original commit

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-02-08 Thread Élie Bouttier
On 24/01/2018 16:44, Stephen Hemminger wrote: > On Wed, 24 Jan 2018 10:19:24 +0100 > Phil Sutter wrote: > >> Hi Stephen, >> >> On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: >>> On Tue, 23 Jan 2018 17:40:47 +0100 >>> Phil Sutter wrote: >>>

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 10:19:24 +0100 Phil Sutter wrote: > Hi Stephen, > > On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: > > On Tue, 23 Jan 2018 17:40:47 +0100 > > Phil Sutter wrote: > > > > > The following command segfaults if enp0s31f6 does not

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Phil Sutter
On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: [...] > Also, it looks like read_family converts any address family it doesn't know > about to unspec > that is stupid behavior as well. I had a closer look and it is the best thing it could do. In all but one cases, the function

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-24 Thread Phil Sutter
Hi Stephen, On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote: > On Tue, 23 Jan 2018 17:40:47 +0100 > Phil Sutter wrote: > > > The following command segfaults if enp0s31f6 does not exist: > > > > | # ip -6 route add default proto ra metric 20100 \ > > | nexthop

Re: [iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-23 Thread Stephen Hemminger
On Tue, 23 Jan 2018 17:40:47 +0100 Phil Sutter wrote: > The following command segfaults if enp0s31f6 does not exist: > > | # ip -6 route add default proto ra metric 20100 \ > | nexthop via fe80:52:0:2040::1fc dev enp0s31f6 weight 1 \ > | nexthop via fe80:52:0:2040::1fe dev

[iproute PATCH] ip-route: Propagate errors from parse_one_nh()

2018-01-23 Thread Phil Sutter
The following command segfaults if enp0s31f6 does not exist: | # ip -6 route add default proto ra metric 20100 \ | nexthop via fe80:52:0:2040::1fc dev enp0s31f6 weight 1 \ | nexthop via fe80:52:0:2040::1fe dev enp0s31f6 weight 1 Since the non-zero return code from parse_one_nh() is