Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-23 Thread Jeff Kirsher
On Mon, 2016-02-22 at 08:33 -0800, Alexander Duyck wrote: > On Wed, Feb 17, 2016 at 7:38 PM, Jeff Kirsher > wrote: > > From: Mitch Williams > > > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > > operators, when we

Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-22 Thread Alexander Duyck
On Wed, Feb 17, 2016 at 7:38 PM, Jeff Kirsher wrote: > From: Mitch Williams > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > operators, when we should clearly be relying on logic. Fascinating. > > Change-ID:

RE: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-22 Thread David Laight
From: Joe Perches > Sent: 18 February 2016 04:59 > On Wed, 2016-02-17 at 19:38 -0800, Jeff Kirsher wrote: > > From: Mitch Williams > > > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > > operators, when we should clearly be relying on logic.

Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-17 Thread Joe Perches
On Wed, 2016-02-17 at 19:38 -0800, Jeff Kirsher wrote: > From: Mitch Williams > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > operators, when we should clearly be relying on logic. Fascinating. I think it read better before this change.

[net-next 13/15] i40e/i40evf: use logical operators, not bitwise

2016-02-17 Thread Jeff Kirsher
From: Mitch Williams Mr. Spock would certainly raise an eyebrow to see us using bitwise operators, when we should clearly be relying on logic. Fascinating. Change-ID: Ie338010c016f93e9faa2002c07c90b15134b7477 Signed-off-by: Mitch Williams