Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 1:35 PM, David Miller wrote: > From: Alexander Duyck > Date: Tue, 1 Mar 2016 13:19:28 -0800 > >> I was wondering what your thoughts would be about widening the size of >> the length field that we pass into csum_tcpudp_magic from a 16 bit to >> a 24 or 32 bit value? The gen

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread David Miller
From: Alexander Duyck Date: Tue, 1 Mar 2016 13:19:28 -0800 > I was wondering what your thoughts would be about widening the size of > the length field that we pass into csum_tcpudp_magic from a 16 bit to > a 24 or 32 bit value? The general idea would be to shift tunnels over > to uniformly using

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread Alexander Duyck
On Tue, Mar 1, 2016 at 12:09 PM, David Miller wrote: > From: Alexander Duyck > Date: Thu, 25 Feb 2016 19:10:59 -0800 > >> This change makes it so that we only use a 16 bit length field instead of a >> 32 bit length field when computing a UDP checksum for IPv6. >> >> This fixes an issue found with

Re: [net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-03-01 Thread David Miller
From: Alexander Duyck Date: Thu, 25 Feb 2016 19:10:59 -0800 > This change makes it so that we only use a 16 bit length field instead of a > 32 bit length field when computing a UDP checksum for IPv6. > > This fixes an issue found with UDP tunnels over IPv6 where the total size > exceeded 65536 f

[net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-02-25 Thread Alexander Duyck
This change makes it so that we only use a 16 bit length field instead of a 32 bit length field when computing a UDP checksum for IPv6. This fixes an issue found with UDP tunnels over IPv6 where the total size exceeded 65536 for a frame that was to be segmented. As a result the checksum being com