Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-05 Thread Alexander Duyck
On Sat, May 5, 2018 at 1:12 AM, Willem de Bruijn wrote: > On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck > wrote: >> From: Alexander Duyck >> >> We should verify that we can pull the UDP header before we attempt to do >> so. Otherwise if this fails we have no way of knowing and GSO will not wor

Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-05 Thread Willem de Bruijn
On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck wrote: > From: Alexander Duyck > > We should verify that we can pull the UDP header before we attempt to do > so. Otherwise if this fails we have no way of knowing and GSO will not work > correctly. This already happened in the callers udp[46]_ufo_

Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-04 Thread Eric Dumazet
On 05/04/2018 11:29 AM, Alexander Duyck wrote: > From: Alexander Duyck > > We should verify that we can pull the UDP header before we attempt to do > so. Otherwise if this fails we have no way of knowing and GSO will not work > correctly. > > Signed-off-by: Alexander Duyck > --- Reviewed-by:

[net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck We should verify that we can pull the UDP header before we attempt to do so. Otherwise if this fails we have no way of knowing and GSO will not work correctly. Signed-off-by: Alexander Duyck --- v2: New break-out patch based on one patch from earlier series net/ipv4/udp