RE: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-18 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Wednesday, November 18, 2020 10:32 AM > To: Keller, Jacob E > Cc: netdev@vger.kernel.org; Jiri Pirko ; Michael Chan > ; Shannon Nelson ; > Saeed Mahameed ; Boris Pismenny > ; Bin Luo > Subject: Re: [net

Re: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 12:10:49 -0800 Jacob Keller wrote: > Oof, forgot to metion that the only change since v2 is to fix the typo > in the commit message pointed out by Shannon. Otherwise, this patch is > identical and just comes in series with the other change. Fine by me, although I thought Shanno

Re: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-18 Thread Jiri Pirko
Tue, Nov 17, 2020 at 09:08:19PM CET, jacob.e.kel...@intel.com wrote: >All drivers which implement the devlink flash update support, with the >exception of netdevsim, use either request_firmware or >request_firmware_direct to locate the firmware file. Rather than having >each driver do this separate

Re: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-18 Thread Vasundhara Volam
On Wed, Nov 18, 2020 at 1:41 AM Jacob Keller wrote: > > > > On 11/17/2020 12:08 PM, Jacob Keller wrote: > > All drivers which implement the devlink flash update support, with the > > exception of netdevsim, use either request_firmware or > > request_firmware_direct to locate the firmware file. Rat

Re: [net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-17 Thread Jacob Keller
On 11/17/2020 12:08 PM, Jacob Keller wrote: > All drivers which implement the devlink flash update support, with the > exception of netdevsim, use either request_firmware or > request_firmware_direct to locate the firmware file. Rather than having > each driver do this separately as part of its

[net-next v3 1/2] devlink: move request_firmware out of driver

2020-11-17 Thread Jacob Keller
All drivers which implement the devlink flash update support, with the exception of netdevsim, use either request_firmware or request_firmware_direct to locate the firmware file. Rather than having each driver do this separately as part of its .flash_update implementation, perform the request_firmw