Re: [PATCH v3 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-22 Thread Shannon Nelson
On 12/22/2017 12:24 AM, Yanjun Zhu wrote: On 2017/12/20 8:00, Shannon Nelson wrote: If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits.  While we're here, we fix an oddly named field in the context descriptor struct. [...]

Re: [PATCH v3 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-22 Thread Yanjun Zhu
On 2017/12/20 8:00, Shannon Nelson wrote: If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. v3: added ifdef CONFIG_XFRM_OFFLOAD check around

[PATCH v3 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-19 Thread Shannon Nelson
If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. v3: added ifdef CONFIG_XFRM_OFFLOAD check around call to ixgbe_ipsec_tx() v2: use ihl != 5

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.15-rc3] [also build test ERROR on next-20171215] [cannot apply to jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread Shannon Nelson
On 12/15/2017 12:10 PM, kbuild test robot wrote: [...] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_xmit_frame_ring': drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:8563:11: error: 'struct sk_buff' has no member named 'sp'; did you mean 'sk'? if (skb->sp &&

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.15-rc3] [also build test ERROR on next-20171215] [cannot apply to jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread Jesse Brandeburg
On Tue, 12 Dec 2017 21:45:13 -0800 Shannon Nelson wrote: > > Also you are still setting the TCP flag for these packets. I'm > > wondering if the TCP flag is really needed. I get that your current > > setup only runs on TCP flows but what about other types of flows? > >

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-12 Thread Shannon Nelson
On 12/12/2017 5:59 PM, Alexander Duyck wrote: On Tue, Dec 12, 2017 at 3:37 PM, Shannon Nelson wrote: If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-12 Thread Alexander Duyck
On Tue, Dec 12, 2017 at 3:37 PM, Shannon Nelson wrote: > If the skb has a security association referenced in the skb, then > set up the Tx descriptor with the ipsec offload bits. While we're > here, we fix an oddly named field in the context descriptor struct. > >

[PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-12 Thread Shannon Nelson
If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. Signed-off-by: Shannon Nelson --- v2: use ihl != 5 move the

Re: [Intel-wired-lan] [next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-07 Thread Shannon Nelson
On 12/7/2017 9:56 AM, Alexander Duyck wrote: You've suggested several things here, all good things to look into, which I will do, most now, some in the near future. Thanks! sln On Wed, Dec 6, 2017 at 9:43 PM, Shannon Nelson wrote: On 12/5/2017 10:13 AM,

Re: [Intel-wired-lan] [next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-07 Thread Alexander Duyck
On Wed, Dec 6, 2017 at 9:43 PM, Shannon Nelson wrote: > On 12/5/2017 10:13 AM, Alexander Duyck wrote: >> >> On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson >> wrote: >>> >>> If the skb has a security association referenced in the skb, then >>>

Re: [Intel-wired-lan] [next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-06 Thread Shannon Nelson
On 12/5/2017 10:13 AM, Alexander Duyck wrote: On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field

Re: [Intel-wired-lan] [next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-05 Thread Alexander Duyck
On Mon, Dec 4, 2017 at 9:35 PM, Shannon Nelson wrote: > If the skb has a security association referenced in the skb, then > set up the Tx descriptor with the ipsec offload bits. While we're > here, we fix an oddly named field in the context descriptor struct. > >

[next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-04 Thread Shannon Nelson
If the skb has a security association referenced in the skb, then set up the Tx descriptor with the ipsec offload bits. While we're here, we fix an oddly named field in the context descriptor struct. Signed-off-by: Shannon Nelson ---