On Wed, Oct 16, 2019 at 5:56 AM <xiangxia.m....@gmail.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m....@gmail.com>
>
> Unlocking of a not locked mutex is not allowed.
> Other kernel thread may be in critical section while
> we unlock it because of setting user_feature fail.
>
> Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain index")
> Cc: Paul Blakey <pa...@mellanox.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m....@gmail.com>
> Tested-by: Greg Rose <gvrose8...@gmail.com>
> ---LGTM Acked-by: William Tu <u9012...@gmail.com> > net/openvswitch/datapath.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c > index 9fea7e1..aeb76e4 100644 > --- a/net/openvswitch/datapath.c > +++ b/net/openvswitch/datapath.c > @@ -1657,6 +1657,7 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct > genl_info *info) > ovs_dp_reset_user_features(skb, info); > } > > + ovs_unlock(); > goto err_destroy_meters; > } > > @@ -1673,7 +1674,6 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct > genl_info *info) > return 0; > > err_destroy_meters: > - ovs_unlock(); > ovs_meters_exit(dp); > err_destroy_ports_array: > kfree(dp->ports); > -- > 1.8.3.1 > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
