Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-13 Thread Jean Tourrilhes
On Fri, Feb 10, 2006 at 02:20:22PM -0500, Dan Williams wrote: Hmm, I'm still confused... Dan Don't worry, you are not the only one being confused... Anyway, I made some decisions, for a change ;-) Wireless Extensions 21 will be the big switch over when ESSID length are the

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-10 Thread Dan Williams
On Thu, 2006-02-09 at 14:18 -0800, Jean Tourrilhes wrote: On Wed, Feb 08, 2006 at 08:06:33PM -0500, John W. Linville wrote: On Mon, Jan 30, 2006 at 02:28:43PM -0800, Jean Tourrilhes wrote: On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-10 Thread Jean Tourrilhes
On Fri, Feb 10, 2006 at 09:33:00AM -0500, Dan Williams wrote: Jean, You mean it would be wise to _not_ commit this patch, right? Yeah, it depend which way you look at it. I was talking of the reverse patch ;-) John: if that's the case (and I think it is?), please back that patch

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-10 Thread Dan Williams
On Fri, 2006-02-10 at 09:07 -0800, Jean Tourrilhes wrote: On Fri, Feb 10, 2006 at 09:33:00AM -0500, Dan Williams wrote: Jean, You mean it would be wise to _not_ commit this patch, right? Yeah, it depend which way you look at it. I was talking of the reverse patch ;-) John:

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-09 Thread Jean Tourrilhes
On Wed, Feb 08, 2006 at 08:06:33PM -0500, John W. Linville wrote: On Mon, Jan 30, 2006 at 02:28:43PM -0800, Jean Tourrilhes wrote: On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the patch I originally sent so that we go back to the original

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-02-08 Thread John W. Linville
On Mon, Jan 30, 2006 at 02:28:43PM -0800, Jean Tourrilhes wrote: On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the patch I originally sent so that we go back to the original behavior. Sorry, I may have overreacted. I think that's a

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Jean Tourrilhes
On Fri, Jan 27, 2006 at 05:01:44PM -0800, Jouni Malinen wrote: On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the ESSID before reporting it in their SIOCGIWESSID handlers. Breaks

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Dan Williams
On Mon, 2006-01-30 at 10:13 -0800, Jean Tourrilhes wrote: On Fri, Jan 27, 2006 at 05:01:44PM -0800, Jouni Malinen wrote: On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Jean Tourrilhes
On Mon, Jan 30, 2006 at 01:28:44PM -0500, Dan Williams wrote: I'll post a revert patch for the patch I originally sent so that we go back to the original behavior. Sorry, I may have overreacted. I think that's a worthwhile change, let's just plan it properly. Dan Jean - To

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-30 Thread Jouni Malinen
On Mon, Jan 30, 2006 at 10:13:16AM -0800, Jean Tourrilhes wrote: On Fri, Jan 27, 2006 at 05:01:44PM -0800, Jouni Malinen wrote: It is spelled very clearly on my web site : --- # The HostAP driver is the reference implementation

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-28 Thread Dan Williams
On Fri, 2006-01-27 at 17:01 -0800, Jouni Malinen wrote: On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the ESSID before reporting it in their SIOCGIWESSID handlers. Breaks stuff

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-28 Thread Jouni Malinen
On Sat, Jan 28, 2006 at 11:07:10AM -0500, Dan Williams wrote: On Fri, 2006-01-27 at 17:01 -0800, Jouni Malinen wrote: On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: 1) The patch preserves the null-termination of the ESSID, it just doesn't return the expanded length to

Re: [patch] drivers/net/wireless: correct reported ssid lengths

2006-01-27 Thread Jouni Malinen
On Thu, Jan 12, 2006 at 03:00:58PM -0500, Dan Williams wrote: ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the ESSID before reporting it in their SIOCGIWESSID handlers. Breaks stuff like wpa_supplicant. Note that ipw drivers, which seem to

[patch] drivers/net/wireless: correct reported ssid lengths

2006-01-12 Thread Dan Williams
Hi, ESSIDs can technically include NULL characters. Drivers should not be adjusting the length of the ESSID before reporting it in their SIOCGIWESSID handlers. Breaks stuff like wpa_supplicant. Note that ipw drivers, which seem to currently be the most correct, don't have this problem.