RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-14 Thread Ayaz Abdulla
Abdulla; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down On Thu, 13 Dec 2007 16:53:58 -0800 Ed Swierk [EMAIL PROTECTED] wrote: On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable

[patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread akpm
From: Ed Swierk [EMAIL PROTECTED] Bring the physical link down when the interface is down by placing the PHY in power-down state, unless WOL is enabled. This mirrors the behavior of other drivers including e1000 and tg3. Signed-off-by: Ed Swierk [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ayaz Abdulla
, 2007 4:03 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ayaz Abdulla Subject: [patch 02/10] forcedeth: power down phy when interface is down From: Ed Swierk [EMAIL PROTECTED] Bring the physical link down when the interface is down by placing the PHY

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ed Swierk
On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link lights both on the NIC and the switch to go out when they bring an interface

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Brandeburg, Jesse
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13, 2007 4:03 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ayaz Abdulla Subject: [patch 02/10] forcedeth: power down phy when interface is down

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13, 2007 4:03 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Ayaz Abdulla Subject: [patch 02/10] forcedeth: power down phy when interface is down From: Ed Swierk

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 16:53:58 -0800 Ed Swierk [EMAIL PROTECTED] wrote: On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link