Re: [patch 03/13] ppp: handle kmalloc() failures

2006-08-15 Thread David Miller
From: Paul Mackerras <[EMAIL PROTECTED]> Date: Tue, 15 Aug 2006 20:09:37 +1000 > secondly, this is a bit rude, isn't it, destroying the whole thing > because one insertion failed? Some existing pppd will come along and > try to use its (previously successfully created) ppp unit and get told > it

Re: [patch 03/13] ppp: handle kmalloc() failures

2006-08-15 Thread Paul Mackerras
[EMAIL PROTECTED] writes: > From: Panagiotis Issaris <[EMAIL PROTECTED]> > > The PPP code contains two kmalloc()s followed by memset()s without handling a > possible memory allocation failure. (Suggested by Joe Perches). Nack, because... > - cardmap_set(&all_ppp_units, unit, ppp); > +

Re: [patch 03/13] ppp: handle kmalloc() failures

2006-08-15 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 14 Aug 2006 23:03:38 -0700 > From: Panagiotis Issaris <[EMAIL PROTECTED]> > > The PPP code contains two kmalloc()s followed by memset()s without handling a > possible memory allocation failure. (Suggested by Joe Perches). > > And furthermore, conversions from

[patch 03/13] ppp: handle kmalloc() failures

2006-08-14 Thread akpm
From: Panagiotis Issaris <[EMAIL PROTECTED]> The PPP code contains two kmalloc()s followed by memset()s without handling a possible memory allocation failure. (Suggested by Joe Perches). And furthermore, conversions from kmalloc+memset to kzalloc. [EMAIL PROTECTED]: fix error-path leak] [EMAIL