Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread David Miller
From: Satyam Sharma <[EMAIL PROTECTED]> Date: Mon, 13 Aug 2007 20:59:09 +0530 (IST) > On Fri, 10 Aug 2007, David Miller wrote: > > > 2) The reiserfs definition is going to define an equivalent > >value, so just adding an #undef and still letting reiserfs > >override is wrong. Why put a c

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread Satyam Sharma
On Mon, 13 Aug 2007, Satyam Sharma wrote: > Hi David, > > > On Fri, 10 Aug 2007, David Miller wrote: > [...] > > 1) The reiserfs definition is better, it is _type_ based. > >Please use (~(__u16)0) and (~(__u32)0), respectively. > > Hmm, in that case ((__u16)0x) and ((__u32)0x)

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread Satyam Sharma
Hi David, On Fri, 10 Aug 2007, David Miller wrote: > From: [EMAIL PROTECTED] > Date: Fri, 10 Aug 2007 14:12:10 -0700 > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > > > Leave out the one in reiserfs_fs.h as it is

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 15:38:19 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: [EMAIL PROTECTED] > Date: Fri, 10 Aug 2007 14:12:10 -0700 > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > > > Leave out the on

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:10 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > Leave out the one in reiserfs_fs.h as it is in the userspace-visible part > of that header. Still, #undef the (equ

[patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> ... in kernel.h and clean up home-grown macros elsewhere in the tree. Leave out the one in reiserfs_fs.h as it is in the userspace-visible part of that header. Still, #undef the (equivalent) kernel version there to avoid seeing "redefined, previous definiti