RE: [patch iproute2] tc: add -bs option for batch mode

2017-12-20 Thread Chris Mi
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, December 20, 2017 11:18 PM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com > Subject: Re: [patch iproute2] tc: add -bs option for batch mode > >

Re: [patch iproute2] tc: add -bs option for batch mode

2017-12-20 Thread David Ahern
On 12/20/17 8:17 AM, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 09:23:34 + > Chris Mi wrote: > >>> Your real performance win is just not asking for ACK for every rule. >> No. Even if batch_size > 1, we ack every rule. The real performance win is >> to send multiple rules in one system c

Re: [patch iproute2] tc: add -bs option for batch mode

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 09:23:34 + Chris Mi wrote: > > Your real performance win is just not asking for ACK for every rule. > No. Even if batch_size > 1, we ack every rule. The real performance win is > to send multiple rules in one system call. If we are not asking for ACK for > every rule, >

RE: [patch iproute2] tc: add -bs option for batch mode

2017-12-20 Thread Chris Mi
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, December 19, 2017 11:23 PM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com > Subject: Re: [patch iproute2] tc: add -bs option for batch mode > > O

Re: [patch iproute2] tc: add -bs option for batch mode

2017-12-20 Thread Or Gerlitz
On Tue, Dec 19, 2017 at 5:15 PM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 15:33:46 +0900 > Chris Mi wrote: > >> Currently in tc batch mode, only one command is read from the batch >> file and sent to kernel to process. With this patch, we can accumulate >> several commands before sending to

Re: [patch iproute2] tc: add -bs option for batch mode

2017-12-19 Thread Stephen Hemminger
On Tue, 19 Dec 2017 15:33:46 +0900 Chris Mi wrote: > Currently in tc batch mode, only one command is read from the batch > file and sent to kernel to process. With this patch, we can accumulate > several commands before sending to kernel. The batch size is specified > using option -bs or -batchsi

Re: [patch iproute2] tc: add -bs option for batch mode

2017-12-19 Thread Stephen Hemminger
On Tue, 19 Dec 2017 15:33:46 +0900 Chris Mi wrote: > Currently in tc batch mode, only one command is read from the batch > file and sent to kernel to process. With this patch, we can accumulate > several commands before sending to kernel. The batch size is specified > using option -bs or -batchsi

[patch iproute2] tc: add -bs option for batch mode

2017-12-18 Thread Chris Mi
Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this patch, we can accumulate several commands before sending to kernel. The batch size is specified using option -bs or -batchsize. To accumulate the commands in tc, we allocate an array o