Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-30 Thread Simon Horman
com; > > xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; > > mawil...@microsoft.com > > Subject: Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR > > > > On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > > > Currently,

RE: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Chris Mi
oft.com > Subject: Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR > > On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > > Currently, all filters with the same priority are linked in a doubly > > linked list. Every filter should have a unique handle.

RE: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Chris Mi
tch net-next 2/3] net/sched: Change cls_flower to use IDR > > On 17-08-28 02:41 AM, Chris Mi wrote: > > Currently, all filters with the same priority are linked in a doubly > > linked list. Every filter should have a unique handle. To make the > > handle unique, we need

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Jamal Hadi Salim
On 17-08-28 02:41 AM, Chris Mi wrote: Currently, all filters with the same priority are linked in a doubly linked list. Every filter should have a unique handle. To make the handle unique, we need to iterate the list every time to see if the handle exists or not when inserting a new filter. It is

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-28 Thread Simon Horman
On Mon, Aug 28, 2017 at 02:41:16AM -0400, Chris Mi wrote: > Currently, all filters with the same priority are linked in a doubly > linked list. Every filter should have a unique handle. To make the > handle unique, we need to iterate the list every time to see if the > handle exists or not when ins

[patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-27 Thread Chris Mi
Currently, all filters with the same priority are linked in a doubly linked list. Every filter should have a unique handle. To make the handle unique, we need to iterate the list every time to see if the handle exists or not when inserting a new filter. It is time-consuming. For example, it takes a