Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-12 Thread Jakub Kicinski
On Fri, 12 Jan 2018 09:20:46 + Nogah Frankel wrote: > > > > > Could we please pass the full qstats on replace and destroy. > > > > > This simplifies the driver code and allows handling the qlen > > > > > as well as backlog. Please see the 2 patch series I sent > > > > > earlier yesterday.

RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-12 Thread Nogah Frankel
ubject: RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO > qdisc > > > > > > +struct tc_prio_qopt_offload_params { > > > > > + int bands; > > > > > + u8 priomap[TC_PRIO_MAX + 1]; > > > > > + /* In

RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Yuval Mintz
> > > > +struct tc_prio_qopt_offload_params { > > > > + int bands; > > > > + u8 priomap[TC_PRIO_MAX + 1]; > > > > + /* In case that a prio qdisc is offloaded and now is changed to > > > > a > > > > +* non-offloadedable config, it needs to update the backlog > > > > value

Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Jakub Kicinski
On Thu, 11 Jan 2018 23:50:27 +, Yuval Mintz wrote: > > > +struct tc_prio_qopt_offload_params { > > > + int bands; > > > + u8 priomap[TC_PRIO_MAX + 1]; > > > + /* In case that a prio qdisc is offloaded and now is changed to a > > > + * non-offloadedable config, it needs to update the backlog va

RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Yuval Mintz
> > +struct tc_prio_qopt_offload_params { > > + int bands; > > + u8 priomap[TC_PRIO_MAX + 1]; > > + /* In case that a prio qdisc is offloaded and now is changed to a > > +* non-offloadedable config, it needs to update the backlog value > > +* to negate the HW backlog value. > > +*

Re: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Jakub Kicinski
On Thu, 11 Jan 2018 11:21:00 +0100, Jiri Pirko wrote: > +struct tc_prio_qopt_offload_params { > + int bands; > + u8 priomap[TC_PRIO_MAX + 1]; > + /* In case that a prio qdisc is offloaded and now is changed to a > + * non-offloadedable config, it needs to update the backlog value >

[patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

2018-01-11 Thread Jiri Pirko
From: Nogah Frankel Add the ability to offload PRIO qdisc by using ndo_setup_tc. There are three commands for PRIO offloading: * TC_PRIO_REPLACE: handles set and tune * TC_PRIO_DESTROY: handles qdisc destroy * TC_PRIO_STATS: updates the qdiscs counters (given as reference) Like RED qdisc, the in