Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-03 Thread Ido Schimmel
Thu, Dec 03, 2015 at 01:20:50AM IST, john.fastab...@gmail.com wrote: >On 15-12-02 12:07 PM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> switchdev drivers reflect the newly requested topology to hardware when >> CHANGEUPPER is received, after software links were already

[patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread Jiri Pirko
From: Ido Schimmel switchdev drivers reflect the newly requested topology to hardware when CHANGEUPPER is received, after software links were already formed. However, the operation can fail and user will not be notified, as the return value of the notifier is not checked.

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread Nikolay Aleksandrov
On 12/02/2015 09:07 PM, Jiri Pirko wrote: > From: Ido Schimmel > > switchdev drivers reflect the newly requested topology to hardware when > CHANGEUPPER is received, after software links were already formed. > However, the operation can fail and user will not be notified, as

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread Or Gerlitz
On Thu, Dec 3, 2015 at 1:20 AM, John Fastabend wrote: > On 15-12-02 12:07 PM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> switchdev drivers reflect the newly requested topology to hardware when >> CHANGEUPPER is received, after software links were

Re: [patch net-next v2 01/28] net: dev: Check CHANGEUPPER notifier return value

2015-12-02 Thread John Fastabend
On 15-12-02 12:07 PM, Jiri Pirko wrote: > From: Ido Schimmel > > switchdev drivers reflect the newly requested topology to hardware when > CHANGEUPPER is received, after software links were already formed. > However, the operation can fail and user will not be notified, as