Re: [patch net 1/2] net: sched: fix clsact init error path

2017-12-15 Thread David Miller
From: Jiri Pirko Date: Fri, 15 Dec 2017 12:40:12 +0100 > From: Jiri Pirko > > Since in qdisc_create, the destroy op is called when init fails, we > don't do cleanup in init and leave it up to destroy. > This fixes use-after-free when trying to put already freed block. > > Fixes: 6e40cf2d4dee (

Re: [patch net 1/2] net: sched: fix clsact init error path

2017-12-15 Thread Cong Wang
On Fri, Dec 15, 2017 at 3:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Since in qdisc_create, the destroy op is called when init fails, we > don't do cleanup in init and leave it up to destroy. > This fixes use-after-free when trying to put already freed block. > > Fixes: 6e40cf2d4dee ("net: s

[patch net 1/2] net: sched: fix clsact init error path

2017-12-15 Thread Jiri Pirko
From: Jiri Pirko Since in qdisc_create, the destroy op is called when init fails, we don't do cleanup in init and leave it up to destroy. This fixes use-after-free when trying to put already freed block. Fixes: 6e40cf2d4dee ("net: sched: use extended variants of block_get/put in ingress and cls