Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 04:01:05PM +0800, Herbert Xu wrote: Hi: The only changes from the last version are that set_ad no longer takes a cryptoff argument and testmgr has been updated to always supply space for the authentication tag. The algif_aead patch has been removed and will be

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
On Wed, 2015-05-27 at 17:07 +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: Right. Unfortunately, I can't typically rely on being able to make changes to the kernel our driver is built against, and I don't think we could do these changes otherwise.

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
On Wed, 2015-05-27 at 16:39 +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: Do you think it'd be feasible at all to somehow override the aead_request_set_crypt() and aead_request_set_ad() functions or so to do something that works on older kernels

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: Not sure if I missed something in the flood of patches, but if I apply your v3 patchset on top of the cryptodev tree, it crashes like that buring boot: Sorry, I forgot to mention that v3 depends on the series of fixes posted

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 11:00:40AM +0200, Johannes Berg wrote: Right. Unfortunately, I can't typically rely on being able to make changes to the kernel our driver is built against, and I don't think we could do these changes otherwise. You could provide your own version of crypto_aead_encrypt

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Johannes Berg
The conversion of in-tree users is fairly straightforward. It is pretty much - but a related question (that you totally don't have to answer if you don't want to think about this). I'm going to have to (continue) backport(ing) this code to older kernels for customer support, and I prefer

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 10:15:50AM +0200, Johannes Berg wrote: Do you think it'd be feasible at all to somehow override the aead_request_set_crypt() and aead_request_set_ad() functions or so to do something that works on older kernels (and thus older crypto subsystems) or do you think I just

Re: [v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 05:29:22PM +0800, Herbert Xu wrote: On Wed, May 27, 2015 at 11:25:33AM +0200, Steffen Klassert wrote: Not sure if I missed something in the flood of patches, but if I apply your v3 patchset on top of the cryptodev tree, it crashes like that buring boot: Sorry,

[v3 PATCH 0/8] crypto: Convert all AEAD users to new interface

2015-05-27 Thread Herbert Xu
Hi: The only changes from the last version are that set_ad no longer takes a cryptoff argument and testmgr has been updated to always supply space for the authentication tag. The algif_aead patch has been removed and will be posted separately. Series description: This series of patches convert