RE: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Ron Mercer
Jeff, Regarding your June 22nd post: 14) Surely there is a better way to down the adapter than masking the interrupts and resetting the adapter? If this is ever used in non-MSI situations (common in Linux today), there is the possibility of screaming interrupts, in shared-interrupt

Re: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Jeff Garzik
Ron Mercer wrote: Jeff, Regarding your June 22nd post: 14) Surely there is a better way to down the adapter than masking the interrupts and resetting the adapter? If this is ever used in non-MSI situations (common in Linux today), there is the possibility of screaming interrupts, in

RE: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Ron Mercer
Freeing a kernel interrupt reservation does not imply that your hardware has stopped delivering them... in a shared interrupt situation, the code sequence free_irq() perform some action could cause the kernel to call _another_ driver's interrupt handling routine over

RE: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-06-28 Thread Ron Mercer
Is the device hotpluggable? If so, this: qdev-index = cards_found; in the probe() handler might do odd things - it'll just keep increasing as the card is removed and re-added. iirc, that's a common problem with net drivers. AFAICT it'll cause only cosmetic oddities here.

Re: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-06-28 Thread Andrew Morton
Ron Mercer [EMAIL PROTECTED] wrote: Is the device hotpluggable? If so, this: qdev-index = cards_found; in the probe() handler might do odd things - it'll just keep increasing as the card is removed and re-added. iirc, that's a common problem with net drivers. AFAICT

Re: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-06-28 Thread Jeff Garzik
Ron Mercer wrote: Is the device hotpluggable? If so, this: qdev-index = cards_found; in the probe() handler might do odd things - it'll just keep increasing as the card is removed and re-added. iirc, that's a common problem with net drivers. AFAICT it'll cause only cosmetic

Re: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-06-28 Thread Doug Maxey
On Wed, 28 Jun 2006 16:07:22 PDT, Ron Mercer wrote: Is the device hotpluggable? If so, this: qdev-index = cards_found; in the probe() handler might do odd things - it'll just keep increasing as the card is removed and re-added. iirc, that's a common problem with net

FW: + qla3xxx-is-bust.patch added to -mm tree

2006-06-26 Thread Ron Mercer
Andrew Morton, The attached patch fixes the compile bugs you indicated plus some of Jeff Garzik's concerns. - Removed non-NAPI code. - Removed un-needed PCI_POSTING macro. - Converted msleep() to ssleep() where waiting 1 sec. - Broke up ql_link_state_machine into two functions for indent