Re: Fix memory allocation in com90xx.c

2006-03-28 Thread Darren Jenkins\\
On Tue, 2006-03-28 at 13:12 +0200, Andi Kleen wrote: >GFP_KERNEL); > > If it's too big for kzalloc then it's too big for kcalloc too. > > -Andi Thanks for that. I seem to have been rather confused about the difference between kzalloc, and kcalloc. Darren J. - To unsubsc

Re: Fix memory allocation in com90xx.c

2006-03-28 Thread Al Viro
On Tue, Mar 28, 2006 at 01:12:25PM +0200, Andi Kleen wrote: > On Monday 27 March 2006 17:41, Darren Jenkins\ wrote: > > > > - shmems = kzalloc(((0x1-0xa) / 0x800) * sizeof(unsigned long), > > + shmems = kcalloc(((0x1-0xa) / 0x800), sizeof(unsigned long), > >

Re: Fix memory allocation in com90xx.c

2006-03-28 Thread Andi Kleen
On Monday 27 March 2006 17:41, Darren Jenkins\ wrote: > - shmems = kzalloc(((0x1-0xa) / 0x800) * sizeof(unsigned long), > + shmems = kcalloc(((0x1-0xa) / 0x800), sizeof(unsigned long), >GFP_KERNEL); If it's too big for kzalloc then it's too big for

Fix memory allocation in com90xx.c

2006-03-27 Thread Darren Jenkins\\
G'day, This has been annoying me since git11, since it is not fixed yet, (git13) I figured I would look at it and send a patch. Someone has probably fixed this somewhere already, but like I said it was annoying me. LD .tmp_vmlinux1 drivers/built-in.o: In function `kzalloc': include/linux