Re: Focusing the XDP project

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:43 PM, Jesper Dangaard Brouer wrote: > On Wed, 22 Feb 2017 09:22:53 -0800 > Tom Herbert wrote: > >> On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer >> wrote: >> > >> > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert >> > wrote: >> >> On Tue, Feb 21, 2017 at 2:2

Re: Focusing the XDP project

2017-02-22 Thread Jesper Dangaard Brouer
On Wed, 22 Feb 2017 09:22:53 -0800 Tom Herbert wrote: > On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer > wrote: > > > > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert > > wrote: > >> On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed > >> wrote: > > [...] > >> > The only complexi

Re: Focusing the XDP project

2017-02-22 Thread Tom Herbert
On Wed, Feb 22, 2017 at 1:43 AM, Jesper Dangaard Brouer wrote: > > On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert wrote: >> On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed >> wrote: > [...] >> > The only complexity XDP is adding to the drivers is the constrains on >> > RX memory management and

Re: Focusing the XDP project

2017-02-22 Thread Jesper Dangaard Brouer
On Tue, 21 Feb 2017 14:54:35 -0800 Tom Herbert wrote: > On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed > wrote: [...] > > The only complexity XDP is adding to the drivers is the constrains on > > RX memory management and memory model, calling the XDP program itself > > and handling the action

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 1:40 AM, Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >> >> >> On 02/20/2017 10:09 PM, Alexander Duyck wrote: >>> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >>> wrote: First thing to bring in order for the XDP proj

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 2:40 PM, Saeed Mahameed wrote: > On Tue, Feb 21, 2017 at 7:40 PM, Tom Herbert wrote: >> On Tue, Feb 21, 2017 at 8:46 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Tue, 21 Feb 2017 08:35:41 -0800 >>> We already have good APIs for similar datapath functional

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 2:29 PM, Saeed Mahameed wrote: > On Tue, Feb 21, 2017 at 6:35 PM, Tom Herbert wrote: >> On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >>> >>> Well, although I think Jesper is a little bit exaggerating ;) I guess he >>> has a point >>> and i am on his side on thi

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 7:40 PM, Tom Herbert wrote: > On Tue, Feb 21, 2017 at 8:46 AM, David Miller wrote: >> From: Tom Herbert >> Date: Tue, 21 Feb 2017 08:35:41 -0800 >> >>> We already have good APIs for similar datapath functionality (GRO, >>> GSO, xmit_more, etc.), and I don't see why XDP is

Re: Focusing the XDP project

2017-02-21 Thread Saeed Mahameed
On Tue, Feb 21, 2017 at 6:35 PM, Tom Herbert wrote: > On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: >> >> Well, although I think Jesper is a little bit exaggerating ;) I guess he has >> a point >> and i am on his side on this discussion. you see, if we define the APIs and >> ABIs now >

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 10:11 AM, David Miller wrote: > From: Tom Herbert > Date: Tue, 21 Feb 2017 09:40:17 -0800 > >> I'd be more supportive of this line of thinking if we (e.g. FB) didn't >> have to spend the majority time over the past few months trying to >> deal with all the complexity being

Re: Focusing the XDP project

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 09:40:17 -0800 > I'd be more supportive of this line of thinking if we (e.g. FB) didn't > have to spend the majority time over the past few months trying to > deal with all the complexity being thrown into drivers for all these > new features such as XDP.

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Tue, Feb 21, 2017 at 8:46 AM, David Miller wrote: > From: Tom Herbert > Date: Tue, 21 Feb 2017 08:35:41 -0800 > >> We already have good APIs for similar datapath functionality (GRO, >> GSO, xmit_more, etc.), and I don't see why XDP is so special that we >> can't come up with a reasonable API f

Re: Focusing the XDP project

2017-02-21 Thread David Miller
From: Tom Herbert Date: Tue, 21 Feb 2017 08:35:41 -0800 > We already have good APIs for similar datapath functionality (GRO, > GSO, xmit_more, etc.), and I don't see why XDP is so special that we > can't come up with a reasonable API for batching and implement it. What you are missing is that it

Re: Focusing the XDP project

2017-02-21 Thread Tom Herbert
On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: > > > On 02/20/2017 10:09 PM, Alexander Duyck wrote: >> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >> wrote: >>> >>> First thing to bring in order for the XDP project: >>> >>> RX batching is missing. >>> >>> I don't want to dis

Re: Focusing the XDP project

2017-02-20 Thread Alexander Duyck
On Mon, Feb 20, 2017 at 3:39 PM, Jesper Dangaard Brouer wrote: > On Mon, 20 Feb 2017 12:09:30 -0800 > Alexander Duyck wrote: > >> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >> wrote: >> > >> > First thing to bring in order for the XDP project: >> > >> > RX batching is missing. >>

Re: Focusing the XDP project

2017-02-20 Thread Alexander Duyck
On Mon, Feb 20, 2017 at 2:57 PM, Saeed Mahameed wrote: > > > On 02/20/2017 10:09 PM, Alexander Duyck wrote: >> On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer >> wrote: >>> >>> First thing to bring in order for the XDP project: >>> >>> RX batching is missing. >>> >>> I don't want to dis

Re: Focusing the XDP project

2017-02-20 Thread Jesper Dangaard Brouer
On Mon, 20 Feb 2017 12:09:30 -0800 Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer > wrote: > > > > First thing to bring in order for the XDP project: > > > > RX batching is missing. > > > > I don't want to discuss packet page-sizes or multi-port forwarding, >

Re: Focusing the XDP project

2017-02-20 Thread Saeed Mahameed
On 02/20/2017 10:09 PM, Alexander Duyck wrote: > On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer > wrote: >> >> First thing to bring in order for the XDP project: >> >> RX batching is missing. >> >> I don't want to discuss packet page-sizes or multi-port forwarding, >> before we have e

Re: Focusing the XDP project

2017-02-20 Thread Alexander Duyck
On Mon, Feb 20, 2017 at 2:13 AM, Jesper Dangaard Brouer wrote: > > First thing to bring in order for the XDP project: > > RX batching is missing. > > I don't want to discuss packet page-sizes or multi-port forwarding, > before we have established the most fundamental principal that all > other s

Focusing the XDP project

2017-02-20 Thread Jesper Dangaard Brouer
First thing to bring in order for the XDP project: RX batching is missing. I don't want to discuss packet page-sizes or multi-port forwarding, before we have established the most fundamental principal that all other solution use; RX batching. Without building in RX batching, from the beginnin